Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: content/renderer/render_frame_impl.h

Issue 1018383002: Make NavigationParams clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/renderer/navigation_state_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 5 #ifndef CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 6 #define CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
7 7
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/basictypes.h" 10 #include "base/basictypes.h"
(...skipping 80 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 class RendererCdmManager; 91 class RendererCdmManager;
92 class RendererMediaPlayerManager; 92 class RendererMediaPlayerManager;
93 class RendererPpapiHost; 93 class RendererPpapiHost;
94 class RenderFrameObserver; 94 class RenderFrameObserver;
95 class RenderViewImpl; 95 class RenderViewImpl;
96 class RenderWidget; 96 class RenderWidget;
97 class RenderWidgetFullscreenPepper; 97 class RenderWidgetFullscreenPepper;
98 class ScreenOrientationDispatcher; 98 class ScreenOrientationDispatcher;
99 class UserMediaClientImpl; 99 class UserMediaClientImpl;
100 enum class SandboxFlags; 100 enum class SandboxFlags;
101 struct CommitNavigationParams;
102 struct CommonNavigationParams; 101 struct CommonNavigationParams;
103 struct CustomContextMenuContext; 102 struct CustomContextMenuContext;
104 struct FrameReplicationState; 103 struct FrameReplicationState;
105 struct HistoryNavigationParams;
106 struct RequestNavigationParams; 104 struct RequestNavigationParams;
107 struct ResourceResponseHead; 105 struct ResourceResponseHead;
108 struct StartNavigationParams; 106 struct StartNavigationParams;
109 107
110 class CONTENT_EXPORT RenderFrameImpl 108 class CONTENT_EXPORT RenderFrameImpl
111 : public RenderFrame, 109 : public RenderFrame,
112 NON_EXPORTED_BASE(public blink::WebFrameClient), 110 NON_EXPORTED_BASE(public blink::WebFrameClient),
113 NON_EXPORTED_BASE(public media::WebMediaPlayerDelegate) { 111 NON_EXPORTED_BASE(public media::WebMediaPlayerDelegate) {
114 public: 112 public:
115 // Creates a new RenderFrame. |render_view| is the RenderView object that this 113 // Creates a new RenderFrame. |render_view| is the RenderView object that this
(...skipping 410 matching lines...) Expand 10 before | Expand all | Expand 10 after
526 524
527 // WebMediaPlayerDelegate implementation: 525 // WebMediaPlayerDelegate implementation:
528 void DidPlay(blink::WebMediaPlayer* player) override; 526 void DidPlay(blink::WebMediaPlayer* player) override;
529 void DidPause(blink::WebMediaPlayer* player) override; 527 void DidPause(blink::WebMediaPlayer* player) override;
530 void PlayerGone(blink::WebMediaPlayer* player) override; 528 void PlayerGone(blink::WebMediaPlayer* player) override;
531 529
532 // TODO(nasko): Make all tests in RenderViewImplTest friends and then move 530 // TODO(nasko): Make all tests in RenderViewImplTest friends and then move
533 // this back to private member. 531 // this back to private member.
534 void OnNavigate(const CommonNavigationParams& common_params, 532 void OnNavigate(const CommonNavigationParams& common_params,
535 const StartNavigationParams& start_params, 533 const StartNavigationParams& start_params,
536 const CommitNavigationParams& commit_params, 534 const RequestNavigationParams& request_params);
537 const HistoryNavigationParams& history_params);
538 535
539 // Make this frame show an empty, unscriptable page. 536 // Make this frame show an empty, unscriptable page.
540 // TODO(nasko): Remove this method once swapped out state is no longer used. 537 // TODO(nasko): Remove this method once swapped out state is no longer used.
541 void NavigateToSwappedOutURL(); 538 void NavigateToSwappedOutURL();
542 539
543 // Binds this render frame's service registry. 540 // Binds this render frame's service registry.
544 void BindServiceRegistry( 541 void BindServiceRegistry(
545 mojo::InterfaceRequest<mojo::ServiceProvider> services, 542 mojo::InterfaceRequest<mojo::ServiceProvider> services,
546 mojo::ServiceProviderPtr exposed_services); 543 mojo::ServiceProviderPtr exposed_services);
547 544
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
635 void OnSelectPopupMenuItems(bool canceled, 632 void OnSelectPopupMenuItems(bool canceled,
636 const std::vector<int>& selected_indices); 633 const std::vector<int>& selected_indices);
637 #elif defined(OS_MACOSX) 634 #elif defined(OS_MACOSX)
638 void OnSelectPopupMenuItem(int selected_index); 635 void OnSelectPopupMenuItem(int selected_index);
639 void OnCopyToFindPboard(); 636 void OnCopyToFindPboard();
640 #endif 637 #endif
641 638
642 void OnCommitNavigation(const ResourceResponseHead& response, 639 void OnCommitNavigation(const ResourceResponseHead& response,
643 const GURL& stream_url, 640 const GURL& stream_url,
644 const CommonNavigationParams& common_params, 641 const CommonNavigationParams& common_params,
645 const CommitNavigationParams& commit_params, 642 const RequestNavigationParams& request_params);
646 const HistoryNavigationParams& history_params);
647 643
648 // Virtual since overridden by WebTestProxy for layout tests. 644 // Virtual since overridden by WebTestProxy for layout tests.
649 virtual blink::WebNavigationPolicy DecidePolicyForNavigation( 645 virtual blink::WebNavigationPolicy DecidePolicyForNavigation(
650 RenderFrame* render_frame, 646 RenderFrame* render_frame,
651 const NavigationPolicyInfo& info); 647 const NavigationPolicyInfo& info);
652 void OpenURL(blink::WebFrame* frame, 648 void OpenURL(blink::WebFrame* frame,
653 const GURL& url, 649 const GURL& url,
654 const Referrer& referrer, 650 const Referrer& referrer,
655 blink::WebNavigationPolicy policy); 651 blink::WebNavigationPolicy policy);
656 652
(...skipping 46 matching lines...) Expand 10 before | Expand all | Expand 10 after
703 699
704 // Creates a factory object used for creating audio and video renderers. 700 // Creates a factory object used for creating audio and video renderers.
705 // The method is virtual so that layouttests can override it. 701 // The method is virtual so that layouttests can override it.
706 virtual scoped_ptr<MediaStreamRendererFactory> CreateRendererFactory(); 702 virtual scoped_ptr<MediaStreamRendererFactory> CreateRendererFactory();
707 703
708 // Checks that the RenderView is ready to display the navigation to |url|. If 704 // Checks that the RenderView is ready to display the navigation to |url|. If
709 // the return value is false, the navigation should be abandoned. 705 // the return value is false, the navigation should be abandoned.
710 bool PrepareRenderViewForNavigation( 706 bool PrepareRenderViewForNavigation(
711 const GURL& url, 707 const GURL& url,
712 bool is_history_navigation, 708 bool is_history_navigation,
713 const HistoryNavigationParams& history_params, 709 const RequestNavigationParams& request_params,
714 bool* is_reload, 710 bool* is_reload,
715 blink::WebURLRequest::CachePolicy* cache_policy); 711 blink::WebURLRequest::CachePolicy* cache_policy);
716 712
717 // PlzNavigate 713 // PlzNavigate
718 // Sends a FrameHostMsg_BeginNavigation to the browser based on the contents 714 // Sends a FrameHostMsg_BeginNavigation to the browser based on the contents
719 // of the WebURLRequest. 715 // of the WebURLRequest.
720 void BeginNavigation(blink::WebURLRequest* request); 716 void BeginNavigation(blink::WebURLRequest* request);
721 717
722 // Loads a data url. 718 // Loads a data url.
723 void LoadDataURL(const CommonNavigationParams& params, 719 void LoadDataURL(const CommonNavigationParams& params,
(...skipping 164 matching lines...) Expand 10 before | Expand all | Expand 10 after
888 #endif 884 #endif
889 885
890 base::WeakPtrFactory<RenderFrameImpl> weak_factory_; 886 base::WeakPtrFactory<RenderFrameImpl> weak_factory_;
891 887
892 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl); 888 DISALLOW_COPY_AND_ASSIGN(RenderFrameImpl);
893 }; 889 };
894 890
895 } // namespace content 891 } // namespace content
896 892
897 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_ 893 #endif // CONTENT_RENDERER_RENDER_FRAME_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/navigation_state_impl.cc ('k') | content/renderer/render_frame_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698