Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(965)

Side by Side Diff: content/renderer/navigation_state_impl.h

Issue 1018383002: Make NavigationParams clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_RENDERER_NAVIGATION_STATE_IMPL_H_ 5 #ifndef CONTENT_RENDERER_NAVIGATION_STATE_IMPL_H_
6 #define CONTENT_RENDERER_NAVIGATION_STATE_IMPL_H_ 6 #define CONTENT_RENDERER_NAVIGATION_STATE_IMPL_H_
7 7
8 #include <string> 8 #include <string>
9 9
10 #include "content/common/navigation_params.h" 10 #include "content/common/navigation_params.h"
11 #include "content/public/renderer/navigation_state.h" 11 #include "content/public/renderer/navigation_state.h"
12 12
13 namespace content { 13 namespace content {
14 14
15 class CONTENT_EXPORT NavigationStateImpl : public NavigationState { 15 class CONTENT_EXPORT NavigationStateImpl : public NavigationState {
16 public: 16 public:
17 ~NavigationStateImpl() override; 17 ~NavigationStateImpl() override;
18 18
19 static NavigationStateImpl* CreateBrowserInitiated( 19 static NavigationStateImpl* CreateBrowserInitiated(
20 const CommonNavigationParams& common_params, 20 const CommonNavigationParams& common_params,
21 const StartNavigationParams& start_params, 21 const StartNavigationParams& start_params,
22 const HistoryNavigationParams& history_params); 22 const RequestNavigationParams& request_params);
23 23
24 static NavigationStateImpl* CreateContentInitiated(); 24 static NavigationStateImpl* CreateContentInitiated();
25 25
26 // NavigationState implementation. 26 // NavigationState implementation.
27 ui::PageTransition GetTransitionType() override; 27 ui::PageTransition GetTransitionType() override;
28 bool WasWithinSamePage() override; 28 bool WasWithinSamePage() override;
29 bool IsContentInitiated() override; 29 bool IsContentInitiated() override;
30 30
31 const CommonNavigationParams& common_params() const { return common_params_; } 31 const CommonNavigationParams& common_params() const { return common_params_; }
32 const StartNavigationParams& start_params() const { return start_params_; } 32 const StartNavigationParams& start_params() const { return start_params_; }
33 const HistoryNavigationParams& history_params() const { 33 const RequestNavigationParams& request_params() const {
34 return history_params_; 34 return request_params_;
35 } 35 }
36 bool request_committed() const { return request_committed_; } 36 bool request_committed() const { return request_committed_; }
37 void set_request_committed(bool value) { request_committed_ = value; } 37 void set_request_committed(bool value) { request_committed_ = value; }
38 void set_was_within_same_page(bool value) { was_within_same_page_ = value; } 38 void set_was_within_same_page(bool value) { was_within_same_page_ = value; }
39 39
40 void set_transition_type(ui::PageTransition transition) { 40 void set_transition_type(ui::PageTransition transition) {
41 common_params_.transition = transition; 41 common_params_.transition = transition;
42 } 42 }
43 43
44 private: 44 private:
45 NavigationStateImpl(const CommonNavigationParams& common_params, 45 NavigationStateImpl(const CommonNavigationParams& common_params,
46 const StartNavigationParams& start_params, 46 const StartNavigationParams& start_params,
47 const HistoryNavigationParams& history_params, 47 const RequestNavigationParams& request_params,
48 bool is_content_initiated); 48 bool is_content_initiated);
49 49
50 bool request_committed_; 50 bool request_committed_;
51 bool was_within_same_page_; 51 bool was_within_same_page_;
52 52
53 // True if this navigation was not initiated via WebFrame::LoadRequest. 53 // True if this navigation was not initiated via WebFrame::LoadRequest.
54 const bool is_content_initiated_; 54 const bool is_content_initiated_;
55 55
56 CommonNavigationParams common_params_; 56 CommonNavigationParams common_params_;
57 const StartNavigationParams start_params_; 57 const StartNavigationParams start_params_;
58 58
59 // Note: if IsContentInitiated() is false, whether this navigation should 59 // Note: if IsContentInitiated() is false, whether this navigation should
60 // replace the current entry in the back/forward history list is determined by 60 // replace the current entry in the back/forward history list is determined by
61 // the should_replace_current_entry field in |history_params|. Otherwise, use 61 // the should_replace_current_entry field in |history_params|. Otherwise, use
62 // replacesCurrentHistoryItem() on the WebDataSource. 62 // replacesCurrentHistoryItem() on the WebDataSource.
63 // 63 //
64 // TODO(davidben): It would be good to unify these and have only one source 64 // TODO(davidben): It would be good to unify these and have only one source
65 // for the two cases. We can plumb this through WebFrame::loadRequest to set 65 // for the two cases. We can plumb this through WebFrame::loadRequest to set
66 // lockBackForwardList on the FrameLoadRequest. However, this breaks process 66 // lockBackForwardList on the FrameLoadRequest. However, this breaks process
67 // swaps because FrameLoader::loadWithNavigationAction treats loads before a 67 // swaps because FrameLoader::loadWithNavigationAction treats loads before a
68 // FrameLoader has committedFirstRealDocumentLoad as a replacement. (Added for 68 // FrameLoader has committedFirstRealDocumentLoad as a replacement. (Added for
69 // http://crbug.com/178380). 69 // http://crbug.com/178380).
70 const HistoryNavigationParams history_params_; 70 const RequestNavigationParams request_params_;
71 71
72 DISALLOW_COPY_AND_ASSIGN(NavigationStateImpl); 72 DISALLOW_COPY_AND_ASSIGN(NavigationStateImpl);
73 }; 73 };
74 74
75 } // namespace content 75 } // namespace content
76 76
77 #endif // CONTENT_RENDERER_NAVIGATION_STATE_IMPL_H_ 77 #endif // CONTENT_RENDERER_NAVIGATION_STATE_IMPL_H_
OLDNEW
« no previous file with comments | « content/renderer/accessibility/renderer_accessibility_browsertest.cc ('k') | content/renderer/navigation_state_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698