Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1228)

Side by Side Diff: content/browser/frame_host/render_frame_host_impl.h

Issue 1018383002: Make NavigationParams clearer (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase + addressed comment Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 5 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 6 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
7 7
8 #include <map> 8 #include <map>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 309 matching lines...) Expand 10 before | Expand all | Expand 10 after
320 320
321 // Sends the given navigation message. Use this rather than sending it 321 // Sends the given navigation message. Use this rather than sending it
322 // yourself since this does the internal bookkeeping described below. This 322 // yourself since this does the internal bookkeeping described below. This
323 // function takes ownership of the provided message pointer. 323 // function takes ownership of the provided message pointer.
324 // 324 //
325 // If a cross-site request is in progress, we may be suspended while waiting 325 // If a cross-site request is in progress, we may be suspended while waiting
326 // for the onbeforeunload handler, so this function might buffer the message 326 // for the onbeforeunload handler, so this function might buffer the message
327 // rather than sending it. 327 // rather than sending it.
328 void Navigate(const CommonNavigationParams& common_params, 328 void Navigate(const CommonNavigationParams& common_params,
329 const StartNavigationParams& start_params, 329 const StartNavigationParams& start_params,
330 const CommitNavigationParams& commit_params, 330 const RequestNavigationParams& request_params);
331 const HistoryNavigationParams& history_params);
332 331
333 // Load the specified URL; this is a shortcut for Navigate(). 332 // Load the specified URL; this is a shortcut for Navigate().
334 void NavigateToURL(const GURL& url); 333 void NavigateToURL(const GURL& url);
335 334
336 // Treat this prospective navigation as though it originated from the frame. 335 // Treat this prospective navigation as though it originated from the frame.
337 // Used, e.g., for a navigation request that originated from a RemoteFrame. 336 // Used, e.g., for a navigation request that originated from a RemoteFrame.
338 // |source_site_instance| is the SiteInstance of the frame that initiated the 337 // |source_site_instance| is the SiteInstance of the frame that initiated the
339 // navigation. 338 // navigation.
340 // TODO(creis): Remove this method and have RenderFrameProxyHost call 339 // TODO(creis): Remove this method and have RenderFrameProxyHost call
341 // RequestOpenURL with its FrameTreeNode. 340 // RequestOpenURL with its FrameTreeNode.
(...skipping 92 matching lines...) Expand 10 before | Expand all | Expand 10 after
434 #elif defined(OS_ANDROID) 433 #elif defined(OS_ANDROID)
435 void DidSelectPopupMenuItems(const std::vector<int>& selected_indices); 434 void DidSelectPopupMenuItems(const std::vector<int>& selected_indices);
436 void DidCancelPopupMenu(); 435 void DidCancelPopupMenu();
437 #endif 436 #endif
438 437
439 // PlzNavigate: Indicates that a navigation is ready to commit and can be 438 // PlzNavigate: Indicates that a navigation is ready to commit and can be
440 // handled by this RenderFrame. 439 // handled by this RenderFrame.
441 void CommitNavigation(ResourceResponse* response, 440 void CommitNavigation(ResourceResponse* response,
442 scoped_ptr<StreamHandle> body, 441 scoped_ptr<StreamHandle> body,
443 const CommonNavigationParams& common_params, 442 const CommonNavigationParams& common_params,
444 const CommitNavigationParams& commit_params, 443 const RequestNavigationParams& request_params);
445 const HistoryNavigationParams& history_params);
446 444
447 // Sets up the Mojo connection between this instance and its associated render 445 // Sets up the Mojo connection between this instance and its associated render
448 // frame if it has not yet been set up. 446 // frame if it has not yet been set up.
449 void SetUpMojoIfNeeded(); 447 void SetUpMojoIfNeeded();
450 448
451 // Tears down the browser-side state relating to the Mojo connection between 449 // Tears down the browser-side state relating to the Mojo connection between
452 // this instance and its associated render frame. 450 // this instance and its associated render frame.
453 void InvalidateMojoConnection(); 451 void InvalidateMojoConnection();
454 452
455 // Returns whether the frame is focused. A frame is considered focused when it 453 // Returns whether the frame is focused. A frame is considered focused when it
(...skipping 287 matching lines...) Expand 10 before | Expand all | Expand 10 after
743 741
744 // NOTE: This must be the last member. 742 // NOTE: This must be the last member.
745 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_; 743 base::WeakPtrFactory<RenderFrameHostImpl> weak_ptr_factory_;
746 744
747 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl); 745 DISALLOW_COPY_AND_ASSIGN(RenderFrameHostImpl);
748 }; 746 };
749 747
750 } // namespace content 748 } // namespace content
751 749
752 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_ 750 #endif // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/frame_host/navigator_impl.cc ('k') | content/browser/frame_host/render_frame_host_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698