Improving WebM video duration estimation.

media/filters/source_buffer_stream.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/filters/source_buffer_stream.h"
 
 #include <algorithm>
 #include <map>
 #include <sstream>
 
@@ skipping 768 matching lines @@
       // position.
       // TODO(acolwell): Figure out a more elegant way to do this.
       SeekAndSetSelectedRange(*range_for_next_append_, seek_timestamp);
       temporarily_select_range = true;
     }
   }
 
   // Handle splices between the existing buffers and the new buffers.  If a
   // splice is generated the timestamp and duration of the first buffer in
   // |new_buffers| will be modified.
-  if (splice_frames_enabled_)
+  if (splice_frames_enabled_) {

[wolenetz, 2015/03/28 00:26:06]

nit: why { } here and not elsewhere like below, and why in this CL?

[chcunningham, 2015/04/13 23:25:18]

Reverted. I see this file has plenty of single liners, so its good to be
consistent. I hate them, but I appear to be in the minority. 

[wolenetz, 2015/04/15 02:55:23]

No, I personally hope you're not in the minority on this.

     GenerateSpliceFrame(new_buffers);
+  }
 
   DecodeTimestamp prev_timestamp = last_appended_buffer_timestamp_;
   bool prev_is_keyframe = last_appended_buffer_is_keyframe_;
   DecodeTimestamp next_timestamp = new_buffers.front()->GetDecodeTimestamp();
   bool next_is_keyframe = new_buffers.front()->is_key_frame();
 
   if (prev_timestamp != kNoDecodeTimestamp() &&
       prev_timestamp != next_timestamp) {
     // Clean up the old buffers between the last appended buffer and the
     // beginning of |new_buffers|.
@@ skipping 761 matching lines @@
     return false;
 
   DCHECK_NE(have_splice_buffers, have_preroll_buffer);
   splice_buffers_index_ = 0;
   pending_buffer_.swap(*out_buffer);
   pending_buffers_complete_ = false;
   return true;
 }
 
 }  // namespace media