Improving WebM video duration estimation.

media/base/decoder_buffer.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef MEDIA_BASE_DECODER_BUFFER_H_
 #define MEDIA_BASE_DECODER_BUFFER_H_
 
 #include <string>
 #include <utility>
 
@@ skipping 68 matching lines @@
   }
 
   void set_duration(base::TimeDelta duration) {
     DCHECK(!end_of_stream());
     DCHECK(duration == kNoTimestamp() ||
            (duration >= base::TimeDelta() && duration != kInfiniteDuration()))
         << duration.InSecondsF();
     duration_ = duration;
   }
 
+  bool is_duration_estimated() { return is_duration_estimated_; }

[wolenetz, 2015/03/28 00:26:05]

nit: const method

[chcunningham, 2015/04/13 23:25:17]

Done.

+
+  void set_is_duration_estimated(bool is_estimated) {

[wolenetz, 2015/03/28 00:26:05]

Must these be in DecoderBuffer? Or is StreamParserBuffer a better place for
these for now? (Does anything downstream of SourceBufferStream care whether or
not a stream parser at some point estimated this buffer's duration, even if it's
been subsequently adjusted?)

[chcunningham, 2015/04/13 23:25:17]

Moved to StreamParserBuffer. SBS is currently the only consumer.

+    is_duration_estimated_ = is_estimated;
+  }
+
   const uint8* data() const {
     DCHECK(!end_of_stream());
     return data_.get();
   }
 
   uint8* writable_data() const {
     DCHECK(!end_of_stream());
     return data_.get();
   }
 
@@ skipping 80 matching lines @@
   // will be padded and aligned as necessary.  If |data| is NULL then |data_| is
   // set to NULL and |buffer_size_| to 0.  |is_key_frame_| will default to
   // false.
   DecoderBuffer(const uint8* data, int size,
                 const uint8* side_data, int side_data_size);
   virtual ~DecoderBuffer();
 
  private:
   base::TimeDelta timestamp_;
   base::TimeDelta duration_;
+  bool is_duration_estimated_;
 
   int size_;
   scoped_ptr<uint8, base::AlignedFreeDeleter> data_;
   int side_data_size_;
   scoped_ptr<uint8, base::AlignedFreeDeleter> side_data_;
   scoped_ptr<DecryptConfig> decrypt_config_;
   DiscardPadding discard_padding_;
   base::TimeDelta splice_timestamp_;
   bool is_key_frame_;
 
   // Constructor helper method for memory allocations.
   void Initialize();
 
   DISALLOW_COPY_AND_ASSIGN(DecoderBuffer);
 };
 
 }  // namespace media
 
 #endif  // MEDIA_BASE_DECODER_BUFFER_H_