Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(314)

Unified Diff: components/nacl/browser/pnacl_translation_cache_unittest.cc

Issue 1018323002: Disable PnaclTranslationCacheTest.GetLargeOnDisk and StoreLargeOnDisk on WinXP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/nacl/browser/pnacl_translation_cache_unittest.cc
diff --git a/components/nacl/browser/pnacl_translation_cache_unittest.cc b/components/nacl/browser/pnacl_translation_cache_unittest.cc
index bfc30522e854c2c9457d797048471ed534d2d18c..dcba62f7b61c7d183096e2585e82f7ccc683c9ef 100644
--- a/components/nacl/browser/pnacl_translation_cache_unittest.cc
+++ b/components/nacl/browser/pnacl_translation_cache_unittest.cc
@@ -15,6 +15,11 @@
#include "net/base/test_completion_callback.h"
#include "testing/gtest/include/gtest/gtest.h"
+// For fine-grained suppression on flaky tests.
+#if defined(OS_WIN)
+#include "base/win/windows_version.h"
+#endif
+
using content::BrowserThread;
using base::FilePath;
@@ -213,6 +218,11 @@ TEST_F(PnaclTranslationCacheTest, StoreSmallOnDisk) {
}
TEST_F(PnaclTranslationCacheTest, StoreLargeOnDisk) {
+#if defined(OS_WIN)
+ // Flaky on XP bot http://crbug.com/468741
+ if (base::win::GetVersion() <= base::win::VERSION_XP)
+ return;
+#endif
// Test a value too large(?) for a single I/O operation
InitBackend(false);
const std::string large_buffer(kLargeNexeSize, 'a');
@@ -247,6 +257,11 @@ TEST_F(PnaclTranslationCacheTest, GetOneOnDisk) {
}
TEST_F(PnaclTranslationCacheTest, GetLargeOnDisk) {
+#if defined(OS_WIN)
+ // Flaky on XP bot http://crbug.com/468741
+ if (base::win::GetVersion() <= base::win::VERSION_XP)
+ return;
+#endif
InitBackend(false);
const std::string large_buffer(kLargeNexeSize, 'a');
StoreNexe(test_key, large_buffer);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698