Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 1018313003: Use libdl to get symbols for backtraces (Closed)

Created:
5 years, 9 months ago by jochen (gone - plz use gerrit)
Modified:
5 years, 9 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Use libdl to get symbols for backtraces With this patch, it'll look like this: $ out/x64.optdebug/d8 --expose-trigger-failure test/mjsunit/mjsunit.js test/mjsunit/verify-assert-false.js ==== C stack trace =============================== 1: V8_Fatal 2: v8::internal::FunctionCallbackArguments::Call(void (*)(v8::FunctionCallbackInfo<v8::Value> const&)) 3: 0x727ced 4: 0x72b6ba 5: 0x188c7f607f9b BUG=none R=svenpanne@chromium.org LOG=y Committed: https://crrev.com/843634994fce8da65323d3ba046d32aefd6eba1a Cr-Commit-Position: refs/heads/master@{#27318}

Patch Set 1 #

Patch Set 2 : updates #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -15 lines) Patch
M BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M src/base/logging.cc View 2 chunks +11 lines, -14 lines 0 comments Download
M tools/gyp/v8.gyp View 1 2 chunks +6 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jochen (gone - plz use gerrit)
5 years, 9 months ago (2015-03-19 14:55:12 UTC) #1
jochen (gone - plz use gerrit)
+jakob ptal
5 years, 9 months ago (2015-03-19 15:18:44 UTC) #3
Jakob Kummerow
Awesome. LGTM.
5 years, 9 months ago (2015-03-19 15:38:34 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018313003/20001
5 years, 9 months ago (2015-03-19 15:39:28 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 9 months ago (2015-03-19 15:43:26 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 15:43:56 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/843634994fce8da65323d3ba046d32aefd6eba1a
Cr-Commit-Position: refs/heads/master@{#27318}

Powered by Google App Engine
This is Rietveld 408576698