Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1018293002: Make fake file audio input device not crash when it fails to read. (Closed)

Created:
5 years, 9 months ago by phoglund_chromium
Modified:
5 years, 9 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make fake file audio input device not crash when it fails to read. The fake device used to just CHECK when it failed to read the file, but I noticed those checks don't make it into the logs for official builds. This makes the --use-file-for-fake-audio-capture flag a bit user-hostile, which has also shown up in Chrome crash reports. This way there will be an entry in the log and the device will be silent instead of crashing. BUG=466408 Committed: https://crrev.com/132678eedf4fb5965f004620923569a5bad5cf31 Cr-Commit-Position: refs/heads/master@{#321365}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -9 lines) Patch
M media/audio/simple_sources.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/audio/simple_sources.cc View 3 chunks +28 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
phoglund_chromium
5 years, 9 months ago (2015-03-19 12:06:27 UTC) #2
henrika (OOO until Aug 14)
LGTM
5 years, 9 months ago (2015-03-19 12:23:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018293002/1
5 years, 9 months ago (2015-03-19 15:01:30 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 16:09:25 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 16:09:52 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/132678eedf4fb5965f004620923569a5bad5cf31
Cr-Commit-Position: refs/heads/master@{#321365}

Powered by Google App Engine
This is Rietveld 408576698