Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: chrome/browser/apps/guest_view/web_view_interactive_browsertest.cc

Issue 1018253002: Disable WebViewInteractiveTest.FullscreenAllow_EmbedderHasPermission on Windows. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "base/strings/stringprintf.h" 5 #include "base/strings/stringprintf.h"
6 #include "base/strings/utf_string_conversions.h" 6 #include "base/strings/utf_string_conversions.h"
7 #include "chrome/app/chrome_command_ids.h" 7 #include "chrome/app/chrome_command_ids.h"
8 #include "chrome/browser/apps/app_browsertest_util.h" 8 #include "chrome/browser/apps/app_browsertest_util.h"
9 #include "chrome/browser/chrome_content_browser_client.h" 9 #include "chrome/browser/chrome_content_browser_client.h"
10 #include "chrome/browser/profiles/profile.h" 10 #include "chrome/browser/profiles/profile.h"
(...skipping 1005 matching lines...) Expand 10 before | Expand all | Expand 10 after
1016 NO_TEST_SERVER); 1016 NO_TEST_SERVER);
1017 } 1017 }
1018 1018
1019 // Disable this on mac, throws an assertion failure on teardown which 1019 // Disable this on mac, throws an assertion failure on teardown which
1020 // will result in flakiness: 1020 // will result in flakiness:
1021 // 1021 //
1022 // "not is fullscreen state" 1022 // "not is fullscreen state"
1023 // "*** Assertion failure in -[_NSWindowFullScreenTransition 1023 // "*** Assertion failure in -[_NSWindowFullScreenTransition
1024 // transitionedWindowFrame]," 1024 // transitionedWindowFrame],"
1025 // See similar bug: http://crbug.com/169820. 1025 // See similar bug: http://crbug.com/169820.
1026 #if defined(OS_MACOSX) 1026 // Also flaky on Windows: http://crbug.com/468660
1027 #if defined(OS_MACOSX) || defined(OS_WIN)
1027 #define MAYBE_FullscreenAllow_EmbedderHasPermission \ 1028 #define MAYBE_FullscreenAllow_EmbedderHasPermission \
1028 DISABLED_FullscreenAllow_EmbedderHasPermission 1029 DISABLED_FullscreenAllow_EmbedderHasPermission
1029 #else 1030 #else
1030 #define MAYBE_FullscreenAllow_EmbedderHasPermission \ 1031 #define MAYBE_FullscreenAllow_EmbedderHasPermission \
1031 FullscreenAllow_EmbedderHasPermission 1032 FullscreenAllow_EmbedderHasPermission
1032 #endif 1033 #endif
1033 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest, 1034 IN_PROC_BROWSER_TEST_F(WebViewInteractiveTest,
1034 MAYBE_FullscreenAllow_EmbedderHasPermission) { 1035 MAYBE_FullscreenAllow_EmbedderHasPermission) {
1035 FullscreenTestHelper("testFullscreenAllow", 1036 FullscreenTestHelper("testFullscreenAllow",
1036 "web_view/fullscreen/embedder_has_permission"); 1037 "web_view/fullscreen/embedder_has_permission");
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
1215 1216
1216 // Now verify that the selection text propagates properly to RWHV. 1217 // Now verify that the selection text propagates properly to RWHV.
1217 content::RenderWidgetHostView* guest_rwhv = 1218 content::RenderWidgetHostView* guest_rwhv =
1218 guest_web_contents()->GetRenderWidgetHostView(); 1219 guest_web_contents()->GetRenderWidgetHostView();
1219 ASSERT_TRUE(guest_rwhv); 1220 ASSERT_TRUE(guest_rwhv);
1220 std::string selected_text = base::UTF16ToUTF8(guest_rwhv->GetSelectedText()); 1221 std::string selected_text = base::UTF16ToUTF8(guest_rwhv->GetSelectedText());
1221 ASSERT_TRUE(selected_text.size() >= 10u); 1222 ASSERT_TRUE(selected_text.size() >= 10u);
1222 ASSERT_EQ("AAAAAAAAAA", selected_text.substr(0, 10)); 1223 ASSERT_EQ("AAAAAAAAAA", selected_text.substr(0, 10));
1223 } 1224 }
1224 #endif 1225 #endif
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698