Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issue 1018243002: [Fetch] Support various operations after reading data partially. (Closed)

Created:
5 years, 9 months ago by yhirano
Modified:
5 years, 9 months ago
Reviewers:
horo
CC:
blink-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, nhiroki, falken, kinuko+serviceworker, horo+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@async-read
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[Fetch] Support various operations after reading data partially. As we agreed to support various operations such as cache.put after reading data partially through the body stream[1], let's support it. 1: https://github.com/slightlyoff/ServiceWorker/issues/452 BUG=435393 R=horo@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192228

Patch Set 1 #

Patch Set 2 : #

Total comments: 6

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -42 lines) Patch
M LayoutTests/http/tests/fetch/script-tests/stream-reader.js View 1 2 1 chunk +26 lines, -0 lines 0 comments Download
M Source/modules/fetch/Body.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/fetch/Body.cpp View 1 2 7 chunks +7 lines, -14 lines 0 comments Download
M Source/modules/fetch/Response.cpp View 1 chunk +1 line, -10 lines 0 comments Download
M Source/modules/serviceworkers/Cache.cpp View 1 2 1 chunk +2 lines, -8 lines 0 comments Download
M Source/modules/serviceworkers/RespondWithObserver.cpp View 1 2 1 chunk +2 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
yhirano
This CL depends on https://codereview.chromium.org/1004623007/ only for the layout test.
5 years, 9 months ago (2015-03-19 07:27:45 UTC) #1
horo
lgtm with nits https://codereview.chromium.org/1018243002/diff/20001/Source/modules/fetch/Body.cpp File Source/modules/fetch/Body.cpp (right): https://codereview.chromium.org/1018243002/diff/20001/Source/modules/fetch/Body.cpp#newcode184 Source/modules/fetch/Body.cpp:184: if (m_drainingStreamBuffer) { nit: we can ...
5 years, 9 months ago (2015-03-20 02:28:54 UTC) #2
yhirano
https://codereview.chromium.org/1018243002/diff/20001/Source/modules/fetch/Body.cpp File Source/modules/fetch/Body.cpp (right): https://codereview.chromium.org/1018243002/diff/20001/Source/modules/fetch/Body.cpp#newcode184 Source/modules/fetch/Body.cpp:184: if (m_drainingStreamBuffer) { On 2015/03/20 02:28:54, horo wrote: > ...
5 years, 9 months ago (2015-03-20 03:24:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018243002/40001
5 years, 9 months ago (2015-03-20 03:25:14 UTC) #6
commit-bot: I haz the power
5 years, 9 months ago (2015-03-20 06:18:34 UTC) #7
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192228

Powered by Google App Engine
This is Rietveld 408576698