sdk/lib/_internal/compiler/implementation/resolution/members.dart - Issue 101823004: We inline List allocations in dart2js to get the right behavior when the passed length is null. Thi…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/resolution/members.dart

Issue 101823004: We inline List allocations in dart2js to get the right behavior when the passed length is null. Thi… (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart

===================================================================

--- sdk/lib/_internal/compiler/implementation/resolution/members.dart (revision 30984)

+++ sdk/lib/_internal/compiler/implementation/resolution/members.dart (working copy)

@@ -324,7 +324,10 @@

originParameter.parseNode(compiler).toString();

String patchParameterText =

patchParameter.parseNode(compiler).toString();

- if (originParameterText != patchParameterText) {

+ if (originParameterText != patchParameterText

+ // We special case the list constructor because of the

+ // optional parameter.

+ && origin != compiler.unnamedListConstructor) {

ahe 2013/12/10 18:57:44 Why is a special case needed? Why can't the publi

ngeoffray 2013/12/10 22:08:31 The patch code says: factory List([int length = co

compiler.reportError(

originParameter.parseNode(compiler),

MessageKind.PATCH_PARAMETER_MISMATCH,

« no previous file with comments | « no previous file | sdk/lib/_internal/lib/core_patch.dart » ('j') | no next file with comments »