We inline List allocations in dart2js to get the right behavior when the passed length is null. Thi…

sdk/lib/_internal/compiler/implementation/resolution/members.dart

Index: sdk/lib/_internal/compiler/implementation/resolution/members.dart
===================================================================
--- sdk/lib/_internal/compiler/implementation/resolution/members.dart	(revision 30984)
+++ sdk/lib/_internal/compiler/implementation/resolution/members.dart	(working copy)
@@ -317,24 +317,19 @@
     while (!originParameters.isEmpty) {
       Element originParameter = originParameters.head;
       Element patchParameter = patchParameters.head;
-      // Hack: Use unparser to test parameter equality. This only works because
-      // we are restricting patch uses and the approach cannot be used
-      // elsewhere.
-      String originParameterText =
-          originParameter.parseNode(compiler).toString();
-      String patchParameterText =
-          patchParameter.parseNode(compiler).toString();
-      if (originParameterText != patchParameterText) {
+      String originParameterName = originParameter.name;
+      String patchParameterName = patchParameter.name;
+      if (originParameterName != patchParameterName) {

[Johnni Winther, 2013/12/09 12:11:01]

With this change, we allow different default values on optional parameters.

I'd prefer if you make as special handling of the List constructor. Before this
check was made we have had unintentional differences and I wan't to avoid that.

[ngeoffray, 2013/12/09 15:24:17]

OK, I have reverted this change and check that the element is the List
constructor instead.

         compiler.reportError(
             originParameter.parseNode(compiler),
             MessageKind.PATCH_PARAMETER_MISMATCH,
             {'methodName': origin.name,
-             'originParameter': originParameterText,
-             'patchParameter': patchParameterText});
+             'originParameter': originParameterName,
+             'patchParameter': patchParameterName});
         compiler.reportMessage(
             compiler.spanFromSpannable(patchParameter),
             MessageKind.PATCH_POINT_TO_PARAMETER.error(
-                {'parameterName': patchParameter.name}),
+                {'parameterName': patchParameterName}),
             Diagnostic.INFO);
       }
       DartType originParameterType = originParameter.computeType(compiler);