Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 1018213004: CSS Parser: Mark on stylesheets whether the first rule was valid (Closed)

Created:
5 years, 9 months ago by Timothy Loh
Modified:
5 years, 9 months ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, blink-reviews-style_chromium.org, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

CSS Parser: Mark on stylesheets whether the first rule was valid This makes the new CSS parser call setHasSyntacticallyValidCSSHeader so that we can determine whether we should allow stylesheets to be used. A StyleRuleCharset class is added so that we can properly signal whether a rule was valid (now consumeAtRule and consumeQualifiedRule will return nullptr exactly when the rule is valid). For more context, the logic regarding disallowing certain stylesheets is discussed in bug 9877. BUG=330389 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192339

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -23 lines) Patch
M LayoutTests/http/tests/security/cross-origin-css.html View 3 chunks +4 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-origin-css-expected.txt View 1 chunk +1 line, -0 lines 0 comments Download
A + LayoutTests/http/tests/security/resources/xorigincss7.html View 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/css/StyleRule.h View 1 2 4 chunks +15 lines, -0 lines 0 comments Download
M Source/core/css/StyleRule.cpp View 5 chunks +11 lines, -0 lines 0 comments Download
M Source/core/css/StyleSheetContents.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/invalidation/StyleSheetInvalidationAnalysis.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/css/parser/CSSParserImpl.h View 2 chunks +4 lines, -1 line 0 comments Download
M Source/core/css/parser/CSSParserImpl.cpp View 5 chunks +31 lines, -18 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
Timothy Loh
5 years, 9 months ago (2015-03-19 07:15:50 UTC) #2
dstockwell
lgtm
5 years, 9 months ago (2015-03-22 23:14:35 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018213004/40001
5 years, 9 months ago (2015-03-22 23:20:00 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/53718)
5 years, 9 months ago (2015-03-23 00:59:02 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018213004/40001
5 years, 9 months ago (2015-03-23 08:25:16 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-23 09:31:25 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192339

Powered by Google App Engine
This is Rietveld 408576698