Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1018133002: [cleanup] Removed embedded sign-in support code from OOBE. (Closed)

Created:
5 years, 9 months ago by dzhioev (left Google)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, dzhioev+watch_chromium.org, arv+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[cleanup] Removed embedded sign-in support code from OOBE. We are not going to use 'EmbeddedSignIn' endpoint for OOBE, so this code could be safely removed. BUG=468439 TEST=manually Committed: https://crrev.com/1a56dc72c7345b3ce3ddd71712650e0943cc48a9 Cr-Commit-Position: refs/heads/master@{#321355}

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -91 lines) Patch
M chrome/browser/chromeos/login/ui/webui_login_view.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js View 1 chunk +0 lines, -6 lines 1 comment Download
M chrome/browser/resources/chromeos/login/screen_gaia_signin.js View 5 chunks +1 line, -13 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.h View 4 chunks +0 lines, -13 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/gaia_screen_handler.cc View 6 chunks +0 lines, -33 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.h View 2 chunks +1 line, -2 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/login/signin_screen_handler.cc View 3 chunks +2 lines, -11 lines 0 comments Download
M chromeos/chromeos_switches.h View 1 chunk +0 lines, -1 line 0 comments Download
M chromeos/chromeos_switches.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M ui/login/display_manager.js View 2 chunks +0 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (5 generated)
dzhioev (left Google)
https://codereview.chromium.org/1018133002/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js File chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js (left): https://codereview.chromium.org/1018133002/diff/1/chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js#oldcode39 chrome/browser/resources/chromeos/login/oobe_screen_oauth_enrollment.js:39: attemptToken_: null, This one is unused.
5 years, 9 months ago (2015-03-18 20:38:27 UTC) #2
dzhioev (left Google)
Please review.
5 years, 9 months ago (2015-03-18 20:38:50 UTC) #3
Roman Sorokin (ftl)
lgtm
5 years, 9 months ago (2015-03-19 09:07:32 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018133002/1
5 years, 9 months ago (2015-03-19 10:04:31 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 9 months ago (2015-03-19 10:04:33 UTC) #8
dzhioev (left Google)
Tania, please review.
5 years, 9 months ago (2015-03-19 11:49:39 UTC) #10
merkulova
lgtm
5 years, 9 months ago (2015-03-19 11:58:30 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018133002/1
5 years, 9 months ago (2015-03-19 14:03:35 UTC) #13
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-19 14:44:52 UTC) #14
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 14:45:27 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/1a56dc72c7345b3ce3ddd71712650e0943cc48a9
Cr-Commit-Position: refs/heads/master@{#321355}

Powered by Google App Engine
This is Rietveld 408576698