Issue 1018123002: Install llvm utils when buidling with cmake

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1018123002: Install llvm utils when buidling with cmake (Closed)

Created:
5 years, 9 months ago by Mircea Trofin

Modified:
5 years, 9 months ago

Reviewers:
Derek Schuff

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master

Target Ref:
refs/heads/master

Project:
nacl

Visibility:
Public.

Use the newly introduced CMake LLVM option, LLVM_INSTALL_UTILS, to install binaries such as FileCheck, as part of the install target. The goal is to replace nacl tests' use of a hand-crafted filecheck tool, with LLVM's FileCheck. A change in the llvm repo, https://codereview.chromium.org/1019043002/, added a cmake flag, LLVM_INSTALL_UTILS. This present change uses that flag when building with cmake. BUG=NONE R=dschuff@chromium.org Committed: https://chromium.googlesource.com/native_client/src/native_client/+/5076f6637e6e1f08f92b0046b066e49e1803f1d3

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -1 line)			Patch
	M	pnacl/COMPONENT_REVISIONS	View	1 2	1 chunk	+1 line, -1 line	0 comments	Download
	M	toolchain_build/toolchain_build_pnacl.py	View		1 chunk	+1 line, -0 lines	0 comments	Download

Total messages: 5 (1 generated)

Derek Schuff

code LGTM; please add some more explanation in the commit message.

5 years, 9 months ago (2015-03-19 22:58:56 UTC) #3

Mircea Trofin

5 years, 9 months ago (2015-03-19 23:17:02 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 (id:60001) manually as
5076f6637e6e1f08f92b0046b066e49e1803f1d3 (presubmit successful).