Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(291)

Issue 1018043005: Allow dev-compiler folder to have a different name, instead check the pubspec (Closed)

Created:
5 years, 9 months ago by Siggi Cherem (dart-lang)
Modified:
5 years, 9 months ago
Reviewers:
Leaf
CC:
dev-compiler+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Allow dev-compiler folder to have a different name, instead check the pubspec file for the package name. R=leafp@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/22d78e3522f89f0d2517eff4e3f7a523eaee57fa

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -11 lines) Patch
M lib/src/utils.dart View 1 2 chunks +15 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-19 21:04:31 UTC) #2
Leaf
lgtm
5 years, 9 months ago (2015-03-19 21:09:04 UTC) #3
Siggi Cherem (dart-lang)
5 years, 9 months ago (2015-03-19 21:10:45 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
22d78e3522f89f0d2517eff4e3f7a523eaee57fa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698