[es6] generate rest parameters correctly for subclass constructors

[es6] generate rest parameters correctly for subclass constructors

BUG=v8:3977
R=dslomov@chromium.org, arv@chromium.org
LOG=N

Committed: https://crrev.com/bef80fcfd7e89cadc215f7d10a016a375e346490
Cr-Commit-Position: refs/heads/master@{#27344}

[caitp (gmail), 2015-03-19 17:52:54]

PTAL

[arv (Not doing code reviews), 2015-03-19 19:12:37]

arv@chromium.org changed reviewers:
+ arv@chromium.org

[arv (Not doing code reviews), 2015-03-19 19:12:38]

LGTM

[Dmitry Lomov (no reviews), 2015-03-20 08:32:46]

looking good, needs some more tests

https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-p...
File test/mjsunit/harmony/rest-params.js (right):

https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-p...
test/mjsunit/harmony/rest-params.js:188: constructor(...a) { this.base = a; }
Please add tests that validate 'arguments'  behavior in these cases.

[caitp (gmail), 2015-03-20 13:28:40]

https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-p...
File test/mjsunit/harmony/rest-params.js (right):

https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-p...
test/mjsunit/harmony/rest-params.js:188: constructor(...a) { this.base = a; }
On 2015/03/20 08:32:46, Dmitry Lomov (chromium) wrote:
> Please add tests that validate 'arguments'  behavior in these cases.

You mean, assert that the arguments elements are identical to the rest parameter
elements? Or the restriction on "caller" / "callee" etc

--- added more to the test for the first part

[Dmitry Lomov (no reviews), 2015-03-20 13:45:15]

lgtm

https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-p...
File test/mjsunit/harmony/rest-params.js (right):

https://codereview.chromium.org/1018043003/diff/1/test/mjsunit/harmony/rest-p...
test/mjsunit/harmony/rest-params.js:188: constructor(...a) { this.base = a; }
On 2015/03/20 13:28:40, caitp wrote:
> On 2015/03/20 08:32:46, Dmitry Lomov (chromium) wrote:
> > Please add tests that validate 'arguments'  behavior in these cases.
> 
> You mean, assert that the arguments elements are identical to the rest
parameter
> elements? Or the restriction on "caller" / "callee" etc
> 
> --- added more to the test for the first part

First part is what I meant - since you indirectly modified code related to
'arguments' object buiilding

[caitp (gmail), 2015-03-20 13:47:09]

The CQ bit was checked by caitpotter88@gmail.com

[caitp (gmail), 2015-03-20 13:47:09]

The patchset sent to the CQ was uploaded after l-g-t-m from arv@chromium.org
Link to the patchset: https://codereview.chromium.org/1018043003/#ps20001
(title: "Test that rest params have same elements as arguments object, too")

[commit-bot: I haz the power, 2015-03-20 13:47:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1018043003/20001

[commit-bot: I haz the power, 2015-03-20 14:07:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-20 14:07:30]

Patchset 2 (id:??) landed as
https://crrev.com/bef80fcfd7e89cadc215f7d10a016a375e346490
Cr-Commit-Position: refs/heads/master@{#27344}