Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(887)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1018003002: Fast user switcher: Add "(Supervised)" label for supervised users (Closed)

Created:
5 years, 9 months ago by Marc Treib
Modified:
5 years, 9 months ago
Reviewers:
msw
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fast user switcher: Add "(Supervised)" label for supervised users BUG=463463 Committed: https://crrev.com/6a94f4486520c68cc71f599597a360d64c148d7d Cr-Commit-Position: refs/heads/master@{#321184}

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -1 line) Patch
M chrome/browser/ui/views/profiles/profile_chooser_view.cc View 1 chunk +7 lines, -1 line 2 comments Download

Messages

Total messages: 8 (2 generated)
Marc Treib
PTAL! Before/after screenshots (from the bug): https://chromium.googlecode.com/issues/attachment?aid=4634630012000&name=fast_user_switcher.png&token=ABZ6GAcAieLrLGW29xOBkCj4oxiKQBp9jg%3A1426674710969&inline=1 https://chromium.googlecode.com/issues/attachment?aid=4634630015000&name=fast_user_switcher_2.png&token=ABZ6GAdGj1n7hfdPcSlI78oO9J5EtTlcBA%3A1426674710973&inline=1
5 years, 9 months ago (2015-03-18 10:38:45 UTC) #2
msw
lgtm with a nit q https://codereview.chromium.org/1018003002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/1018003002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode1297 chrome/browser/ui/views/profiles/profile_chooser_view.cc:1297: title = l10n_util::GetStringFUTF16(IDS_SUPERVISED_USER_NEW_AVATAR_LABEL, nit ...
5 years, 9 months ago (2015-03-18 17:15:04 UTC) #3
Marc Treib
https://codereview.chromium.org/1018003002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc File chrome/browser/ui/views/profiles/profile_chooser_view.cc (right): https://codereview.chromium.org/1018003002/diff/1/chrome/browser/ui/views/profiles/profile_chooser_view.cc#newcode1297 chrome/browser/ui/views/profiles/profile_chooser_view.cc:1297: title = l10n_util::GetStringFUTF16(IDS_SUPERVISED_USER_NEW_AVATAR_LABEL, On 2015/03/18 17:15:03, msw wrote: > ...
5 years, 9 months ago (2015-03-18 18:12:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1018003002/1
5 years, 9 months ago (2015-03-18 18:12:20 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-18 19:07:27 UTC) #7
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 19:08:47 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/6a94f4486520c68cc71f599597a360d64c148d7d
Cr-Commit-Position: refs/heads/master@{#321184}

Powered by Google App Engine
This is Rietveld 408576698