Add some instrumentation to investigate a possible UAF.

Add some instrumentation to investigate a possible UAF.

BUG=467797
Committed: https://crrev.com/93f8ac25b585f1922597dc42d32c3fce8f802a8b
Cr-Commit-Position: refs/heads/master@{#321274}

[eroman, 2015-03-18 01:43:18]

eroman@chromium.org changed reviewers:
+ mmenke@chromium.org

[mmenke, 2015-03-18 13:20:40]

Need to fix those compile under NACL errors, but otherwise, looks good.

[eroman, 2015-03-18 23:27:55]

Still trying to figure out the nacl errors.

I think the problem is that libnet_nacl includes a subset of net/ files. the
net_log.* happen to be in that set.

libnet_nacl does not compile with //base, but rather uses base_nacl which is a
very limited set of things, and does not include base/debug/stack_trace*.

building is not complaining about unexpected header dependency, but instead
fails when linking due to not finding ~StackTrace().

Investigating ways to fix this. The easiest approach would be to ifdef this out
when being built for libnet_nacl. I just need to find an existing #define that I
can use now...

[mmenke, 2015-03-18 23:58:38]

On 2015/03/18 23:27:55, eroman wrote:
> Still trying to figure out the nacl errors.
> 
> I think the problem is that libnet_nacl includes a subset of net/ files. the
> net_log.* happen to be in that set.
> 
> libnet_nacl does not compile with //base, but rather uses base_nacl which is a
> very limited set of things, and does not include base/debug/stack_trace*.
> 
> building is not complaining about unexpected header dependency, but instead
> fails when linking due to not finding ~StackTrace().
> 
> Investigating ways to fix this. The easiest approach would be to ifdef this
out
> when being built for libnet_nacl. I just need to find an existing #define that
I
> can use now...

#if defined(OS_NACL), I think?

[eroman, 2015-03-19 00:02:21]

Added some guards, PTAL

[mmenke, 2015-03-19 00:05:43]

LGTM

[eroman, 2015-03-19 00:10:45]

The CQ bit was checked by eroman@chromium.org

[commit-bot: I haz the power, 2015-03-19 00:11:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1017913003/20001

[commit-bot: I haz the power, 2015-03-19 02:41:40]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-03-19 02:42:49]

Patchset 2 (id:??) landed as
https://crrev.com/93f8ac25b585f1922597dc42d32c3fce8f802a8b
Cr-Commit-Position: refs/heads/master@{#321274}