chrome/browser/bookmarks/enhanced_bookmarks_features.h - Issue 1017913002: Force Enhanced Bookmark to be enabled if command line flags are set true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/bookmarks/enhanced_bookmarks_features.h

Issue 1017913002: Force Enhanced Bookmark to be enabled if command line flags are set true (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Did a further refactoring and created a universal isEnhancedBookmarkEnabled method Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/bookmarks/OWNERS ('k') | chrome/browser/bookmarks/enhanced_bookmarks_features.cc » ('j') | chrome/browser/bookmarks/enhanced_bookmarks_features.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/bookmarks/enhanced_bookmarks_features.h

diff --git a/chrome/browser/bookmarks/enhanced_bookmarks_features.h b/chrome/browser/bookmarks/enhanced_bookmarks_features.h

index 8e6a98701678473f7693b6ca247dbb33a3f2220c..7548fecca88f6b797c46c7ecf0904b55c35417dd 100644

--- a/chrome/browser/bookmarks/enhanced_bookmarks_features.h

+++ b/chrome/browser/bookmarks/enhanced_bookmarks_features.h

@@ -22,9 +22,14 @@ bool IsEnhancedBookmarkImageFetchingEnabled(const PrefService* user_prefs);

// Returns true if enhanced bookmarks is enabled.

bool IsEnhancedBookmarksEnabled();

#endif

+// Returns true and sets |extension_id| if enhanced bookmarks experiment is

+// enabled. Returns false if no bookmark experiment or extension id is empty.

+// Unlike GetBookmarksExperimentExtensionID(), this method takes commandline

+// flags into account before trying to get an extension_id.

+bool IsEnhancedBookmarksEnabled(std::string* extension_id);

// Returns true when flag enable-dom-distiller is set or enabled from Finch.

bool IsEnableDomDistillerSet();