Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1017863005: [Files.app] Fix the tabindex around search box (Closed)

Created:
5 years, 9 months ago by yoshiki
Modified:
5 years, 9 months ago
Reviewers:
fukino
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Files.app] Fix the tabindex around search box Redesign of MD introduce strange tabfocus behavior around searchBox. This patch fixes it. BUG=467872 TEST=browsertets pass Committed: https://crrev.com/c580f60d3879162b606d2836a116019878505bfa Cr-Commit-Position: refs/heads/master@{#321358}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : Adressed comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -7 lines) Patch
M ui/file_manager/file_manager/foreground/js/ui/search_box.js View 1 2 4 chunks +12 lines, -5 lines 0 comments Download
M ui/file_manager/integration_tests/file_manager/tab_index.js View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (2 generated)
yoshiki
@fukino-san, PTAL. Thanks.
5 years, 9 months ago (2015-03-18 12:45:42 UTC) #2
fukino
Does this CL fix crbug.com/467872? (If so, could you add the bug number for this ...
5 years, 9 months ago (2015-03-19 03:26:00 UTC) #3
yoshiki
On 2015/03/19 03:26:00, fukino wrote: > Does this CL fix crbug.com/467872? > (If so, could ...
5 years, 9 months ago (2015-03-19 05:01:48 UTC) #4
yoshiki
@fukino-san, PTAL. Thanks. https://codereview.chromium.org/1017863005/diff/20001/ui/file_manager/file_manager/foreground/js/ui/search_box.js File ui/file_manager/file_manager/foreground/js/ui/search_box.js (right): https://codereview.chromium.org/1017863005/diff/20001/ui/file_manager/file_manager/foreground/js/ui/search_box.js#newcode81 ui/file_manager/file_manager/foreground/js/ui/search_box.js:81: TEXT_CHANGE: 'textcange', On 2015/03/19 03:25:59, fukino ...
5 years, 9 months ago (2015-03-19 09:04:23 UTC) #5
fukino
lgtm. Thanks!
5 years, 9 months ago (2015-03-19 12:10:34 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017863005/40001
5 years, 9 months ago (2015-03-19 14:22:52 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 14:54:10 UTC) #9
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 14:55:14 UTC) #10
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/c580f60d3879162b606d2836a116019878505bfa
Cr-Commit-Position: refs/heads/master@{#321358}

Powered by Google App Engine
This is Rietveld 408576698