Issue 1017863003: Rename to avoid redefining a builtin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1017863003: Rename to avoid redefining a builtin. (Closed)

Created:
5 years, 9 months ago by aiolos (Not reviewing)

Modified:
5 years, 9 months ago

Reviewers:
nednguyen, dtu

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Rename to avoid redefining a builtin. BUG=467260 Committed: https://crrev.com/a0d04a4b92ef73dba23edc98e54df22bfff3d754 Cr-Commit-Position: refs/heads/master@{#320985}

Patch Set 1 #

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	tools/update_reference_build.py	View		1 chunk	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

aiolos (Not reviewing)

On 2015/03/17 21:20:20, aiolos wrote: > mailto:aiolos@chromium.org changed reviewers: > + mailto:dtu@chromium.org, mailto:nednguyen@google.com This fixes ...

5 years, 9 months ago (2015-03-17 21:21:35 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017863003/1

5 years, 9 months ago (2015-03-17 21:26:44 UTC) #5

commit-bot: I haz the power

5 years, 9 months ago (2015-03-17 21:50:39 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/a0d04a4b92ef73dba23edc98e54df22bfff3d754
Cr-Commit-Position: refs/heads/master@{#320985}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages