Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2270)

Unified Diff: chrome/gles2_conform_test.isolate

Issue 101783011: Added isolates for remaining tests on GPU bots. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Addressed maruel's review feedback. Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/gl_tests.isolate ('k') | chrome/tab_capture_performance_tests.isolate » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/gles2_conform_test.isolate
diff --git a/chrome/gles2_conform_test.isolate b/chrome/gles2_conform_test.isolate
new file mode 100644
index 0000000000000000000000000000000000000000..b2711bb8d57d915a96bfad6ce1e37a16522cddc7
--- /dev/null
+++ b/chrome/gles2_conform_test.isolate
@@ -0,0 +1,39 @@
+# Copyright 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+{
+ 'conditions': [
+ # TODO(kbr): add Android when these tests are run on those bots.
+ ['OS=="linux" or OS=="mac" or OS=="win"', {
+ 'variables': {
+ 'command': [
+ '<(PRODUCT_DIR)/gles2_conform_test<(EXECUTABLE_SUFFIX)',
+ ],
+ 'isolate_dependency_tracked': [
+ '<(PRODUCT_DIR)/gles2_conform_test<(EXECUTABLE_SUFFIX)',
+ '../gpu/gles2_conform_support/gles2_conform_test_expectations.txt',
+ ],
+ },
+ }],
+ # .isolate format doesn't support nested conditions.
+ ['(OS=="linux" or OS=="mac" or OS=="win") and internal_gles2_conform_tests==1', {
+ 'variables': {
+ 'isolate_dependency_tracked': [
+ '<(PRODUCT_DIR)/gles2_conform_test_windowless<(EXECUTABLE_SUFFIX)',
+ # Could add gles2_conform_test_angle or
+ # gles2_conform_test_chromeos if the bots were testing those.
+ ],
+ 'isolate_dependency_untracked': [
+ '../third_party/gles2_conform/GTF_ES/',
+ ],
+ },
+ }],
+ # This no-op branch should not be necessary but seems to be.
M-A Ruel 2014/01/07 00:31:46 What happened otherwise? I consider this a bug in
Ken Russell (switch to Gerrit) 2014/01/07 00:42:54 Issue 331957 filed about the error which occurs if
+ ['(OS=="linux" or OS=="mac" or OS=="win") and internal_gles2_conform_tests==0', {
+ 'variables': {
+ 'isolate_dependency_tracked': [
+ ],
+ },
+ }],
+ ],
+}
« no previous file with comments | « chrome/gl_tests.isolate ('k') | chrome/tab_capture_performance_tests.isolate » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698