Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 1017783004: Copy PassphraseActivity upstream. (Closed)

Created:
5 years, 9 months ago by maxbogue
Modified:
5 years, 9 months ago
Reviewers:
nyquist, newt (away)
CC:
chromium-reviews, maniscalco+watch_chromium.org, maxbogue+watch_chromium.org, plaree+watch_chromium.org, pvalenzuela+watch_chromium.org, tim+watch_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Copy PassphraseActivity upstream. No changes aside from package/imports. BUG=428882 Committed: https://crrev.com/98bfcc82979e3257b73d8a6dbe5170efe2eaed37 Cr-Commit-Position: refs/heads/master@{#321270}

Patch Set 1 #

Patch Set 2 : Revert PassphraseDialogFragment change until downstream side lands. #

Total comments: 4

Patch Set 3 : Remove unnecessary resource. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -0 lines) Patch
A chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseActivity.java View 1 2 1 chunk +153 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
maxbogue
PTAL!
5 years, 9 months ago (2015-03-18 20:25:51 UTC) #2
newt (away)
https://codereview.chromium.org/1017783004/diff/20001/chrome/android/java/res/layout/sync_passphrase_activity.xml File chrome/android/java/res/layout/sync_passphrase_activity.xml (right): https://codereview.chromium.org/1017783004/diff/20001/chrome/android/java/res/layout/sync_passphrase_activity.xml#newcode1 chrome/android/java/res/layout/sync_passphrase_activity.xml:1: <?xml version="1.0" encoding="utf-8"?> This layout isn't needed. https://codereview.chromium.org/1017783004/diff/20001/chrome/android/java/src/org/chromium/chrome/browser/sync/ui/PassphraseActivity.java File ...
5 years, 9 months ago (2015-03-18 20:34:23 UTC) #3
maxbogue
https://codereview.chromium.org/1017783004/diff/20001/chrome/android/java/res/layout/sync_passphrase_activity.xml File chrome/android/java/res/layout/sync_passphrase_activity.xml (right): https://codereview.chromium.org/1017783004/diff/20001/chrome/android/java/res/layout/sync_passphrase_activity.xml#newcode1 chrome/android/java/res/layout/sync_passphrase_activity.xml:1: <?xml version="1.0" encoding="utf-8"?> On 2015/03/18 20:34:23, newt wrote: > ...
5 years, 9 months ago (2015-03-18 21:05:57 UTC) #4
newt (away)
lgtm
5 years, 9 months ago (2015-03-18 21:12:31 UTC) #5
nyquist
lgtm
5 years, 9 months ago (2015-03-18 22:07:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017783004/40001
5 years, 9 months ago (2015-03-18 22:08:23 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_TIMED_OUT, no build URL) Timed out ...
5 years, 9 months ago (2015-03-19 02:09:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017783004/40001
5 years, 9 months ago (2015-03-19 02:11:57 UTC) #12
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 9 months ago (2015-03-19 02:17:53 UTC) #13
commit-bot: I haz the power
5 years, 9 months ago (2015-03-19 02:18:20 UTC) #14
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/98bfcc82979e3257b73d8a6dbe5170efe2eaed37
Cr-Commit-Position: refs/heads/master@{#321270}

Powered by Google App Engine
This is Rietveld 408576698