Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1806)

Side by Side Diff: net/docs/bug-triage-labels.md

Issue 1017743002: [net] Convert bug triage documents to Markdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Comments Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Chrome Network Bug Triage : Labels
2
3 ## Some network label caveats
4
5 * **Cr-UI-Browser-Downloads**: Despite the name, this covers all issues
6 related to downloading a file except saving entire pages (Which is
7 **Cr-Blink-SavePage**), not just UI issues. Most downloads bugs will have
8 the word "download" or "save as" in the description. Issues with the HTTP
9 server for the Chrome binaries are not downloads bugs.
10
11 * **Cr-UI-Browser-SafeBrowsing**: Bugs that have to do with the process by
12 which a URL or file is determined to be dangerous based on our databases, or
13 the resulting interstitials. Determination of danger based purely on
14 content-type or file extension belongs in **Cr-UI-Browser-Downloads**, not
15 SafeBrowsing.
16
17 * **Cr-Internals-Network-SSL**: This includes issues that should be also
18 tagged as **Cr-Security-UX** (certificate error pages or other security
19 interstitials, omnibox indicators that a page is secure), and more general
20 SSL issues. If you see requests that die in the SSL negotiation phase, in
21 particular, this is often the correct label.
22
23 * **Cr-Internals-Network-DataProxy**: Flywheel / the Data Reduction Proxy.
24 Issues require "Reduce Data Usage" be turned on. Proxy url is
25 [https://proxy.googlezip.net:443], with [http://compress.googlezip.net:80] as
26 a fallback. Currently Android and iOS only.
27
28 * **Cr-Internals-Network-Cache**: The cache is the layer that handles most
29 range request logic (Though range requests may also be issued by the PDF
30 plugin, XHRs, or other components).
31
32 * **Cr-Internals-Network-SPDY**: Covers HTTP2 as well.
33
34 * **Cr-Internals-Network-HTTP**: Typically not used. Unclear what it covers,
35 and there's no specific HTTP owner.
36
37 * **Cr-Internals-Network-Logging**: Covers **about:net-internals**,
38 **about:net-export** as well as the what's sent to the NetLog.
39
40 * **Cr-Internals-Network-Connectivity**: Issues related to switching between
41 networks, ERR_NETWORK_CHANGED, Chrome thinking it's online when it's not /
42 navigator.onLine inaccuracies, etc.
43
44 * **Cr-Internals-Network-Filters**: Covers SDCH and gzip issues.
45 ERR_CONTENT_DECODING_FAILED indicates a problem at this layer, and bugs here
46 can also cause response body corruption.
47
48
49 ## Common non-network labels
50
51 Bugs in these areas often receive the **Cr-Internals-Network** label, though
52 they fall largely outside the purview of the network stack team:
53
54 * **Cr-Blink-Forms**: Issues submitting forms, forms having weird data, forms
55 sending the wrong method, etc.
56
57 * **Cr-Blink-Loader**: Cross origin issues are sometimes loader related.
58 Blink also has an in-memory cache, and when it's used, requests don't appear
59 in about:net-internals. Requests for the same URL are also often merged
60 there as well. This does *not* cover issues with content/browser/loader/
61 files.
62
63 * **Cr-Blink-ServiceWorker**
64
65 * **Cr-Blink-Storage-AppCache**
66
67 * **Cr-Blink-WebSockets**
68
69 * **Cr-Blink-XHR**: Generic issues with sync/async XHR requests - missing
70 request or response headers, multiple headers, etc. These will often run
71 into issues in certain corner cases (Cross origin / CORS, proxy, whatever).
72 Attach all labels that seem appropriate.
73
74 * **Cr-Services-Sync**: Sharing data/tabs/history/passwords/etc between
75 machines not working.
76
77 * **Cr-Services-Chromoting**
78
79 * **Cr-Platform-Extensions**: Issues extensions loading / not loading /
80 hanging.
81
82 * **Cr-Platform-Extensions-API**: Issues with network related extension APIs
83 should have this label. chrome.webRequest is the big one, I believe, but
84 there are others.
85
86 * **Cr-Internals-Plugins-Pepper[-SDK]**
87
88 * **Cr-UI-Browser-Omnibox**: Basically any issue with the omnibox. URLs being
89 treated as search queries rather than navigations, dropdown results being
90 weird, not handling certain unicode characters, etc. If the issue is new
91 TLDs not being recognized by the omnibox, that's due to Chrome's TLD list
92 being out of date, and not an omnibox issue. Such TLD issues should be duped
93 against http://crbug.com/37436.
94
95 * **Cr-Internals-Media-Network**: Issues related to media. These often run
96 into the 6 requests per hostname issue, and also have fun interactions with
97 the cache, particularly in the range request case.
98
99 * **Cr-Internals-Plugins-PDF**: Issues loading pdf files. These are often
100 related to range requests, which also have some logic at the
101 Internals-Network-Cache layer.
102
103 * **Cr-UI-Browser-Navigation**
104
105 * **Cr-UI-Browser-History**: Issues which only appear with forward/back
106 navigation.
107
108 * **Cr-OS-Systems-Network** / **Cr-OS-Systems-Mobile** /
109 **Cr-OS-Systems-Bluetooth**: These should be used for issues with ChromeOS's
110 platform network code, and not net/ issues on ChromeOS.
111
112 * **Cr-Blink-SecurityFeature**: CORS / Cross origin issues. Main frame
113 cross-origin navigation issues are often actually
114 **Cr-UI-Browser-Navigation** issues.
115
116 * **Cr-Privacy**: Privacy related bug (History, cookies discoverable by an
117 entity that shouldn't be able to do so, incognito state being saved in memory
118 or on disk beyond the lifetime of incognito tabs, etc). Generally used in
119 conjunction with other labels.
120
121 * **Type-Bug-Security**: Security related bug (Allows for code execution from
122 remote site, allows crossing security boundaries, unchecked array bounds,
123 etc).
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698