Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(864)

Side by Side Diff: net/docs/bug-triage-labels.md

Issue 1017743002: [net] Convert bug triage documents to Markdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 # Chrome Network Bug Triage : Labels
2
3 ## Some network label caveats
4
5 * `Cr-UI-Browser-Downloads`: Despite the name, this covers all issues related
6 to downloading a file except saving entire pages (Which is
7 `Cr-Blink-SavePage`), not just UI issues. Most downloads bugs will have the
8 word "download" or "save as" in the description. Issues with the HTTP server
9 for the Chrome binaries are not downloads bugs.
10 * `Cr-UI-Browser-SafeBrowsing`: Bugs that have to do with the process by which
11 a URL or file is determined to be dangerous based on our databases, or the
12 resulting interstitials. Determination of danger based purely on content-type
13 or file extension belongs in `Cr-UI-Browser-Downloads`, not SafeBrowsing.
14 * `Cr-Internals-Network-SSL`: This includes issues that should be also tagged
15 as `Cr-Security-UX` (certificate error pages or other security interstitials,
16 omnibox indicators that a page is secure), and more general SSL issues. If
17 you see requests that die in the SSL negotiation phase, in particular, this
18 is often the correct label.
19 * `Cr-Internals-Network-DataProxy`: Flywheel / the Data Reduction Proxy.
20 Issues require "Reduce Data Usage" be turned on. Proxy url is
21 https://proxy.googlezip.net:443, with compress.googlezip.net:80 as a
Randy Smith (Not in Mondays) 2015/03/17 19:49:57 This shows the proxy url as an actual link in the
asanka 2015/03/17 22:23:13 Unlinkified.
22 fallback. Currently Android and iOS only.
23 * `Cr-Internals-Network-Cache`: The cache is the layer that handles most range
24 request logic (Though range requests may also be issued by the PDF plugin,
25 XHRs, or other components).
26 * `Cr-Internals-Network-SPDY`: Covers HTTP2 as well.
27 * `Cr-Internals-Network-HTTP`: Typically not used. Unclear what it covers,
28 and there's no specific HTTP owner.
29 * `Cr-Internals-Network-Logging`: Covers `about:net-internals`,
30 `about:net-export` as well as the what's sent to the NetLog.
31 * `Cr-Internals-Network-Connectivity`: Issues related to switching between
32 networks, `ERR_NETWORK_CHANGED`, Chrome thinking it's online when it's not /
33 navigator.onLine inaccuracies, etc.
34 * `Cr-Internals-Network-Filters`: Covers SDCH and gzip issues.
35 `ERR_CONTENT_DECODING_FAILED` indicates a problem at this layer, and bugs
36 here can also cause response body corruption.
37
38
39 ## Common non-network labels
40
41 Bugs in these areas often receive the `Cr-Internals-Network` label, though they
42 fall largely outside the purview of the network stack team:
43
44 * `Cr-Blink-Forms`: Issues submitting forms, forms having weird data, forms
45 sending the wrong method, etc.
46 * `Cr-Blink-Loader`: Cross origin issues are sometimes loader related. Blink
47 also has an in-memory cache, and when it's used, requests don't appear in
48 about:net-internals. Requests for the same URL are also often merged there
49 as well. This does *not* cover issues with content/browser/loader/ files.
50 * `Cr-Blink-ServiceWorker`
51 * `Cr-Blink-Storage-AppCache`
52 * `Cr-Blink-WebSockets`
53 * `Cr-Blink-XHR`: Generic issues with sync/async XHR requests - missing
54 request or response headers, multiple headers, etc. These will often run
55 into issues in certain corner cases (Cross origin / CORS, proxy, whatever).
56 Attach all labels that seem appropriate.
57 * `Cr-Services-Sync`: Sharing data/tabs/history/passwords/etc between machines
58 not working.
59 * `Cr-Services-Chromoting`
60 * `Cr-Platform-Extensions`: Issues extensions loading / not loading / hanging.
61 * `Cr-Platform-Extensions-API`: Issues with network related extension APIs
62 should have this label. chrome.webRequest is the big one, I believe, but
63 there are others.
64 * `Cr-Internals-Plugins-Pepper[-SDK]`
65 * `Cr-UI-Browser-Omnibox`: Basically any issue with the omnibox. URLs being
66 treated as search queries rather than navigations, dropdown results being
67 weird, not handling certain unicode characters, etc. If the issue is new
68 TLDs not being recognized by the omnibox, that's due to Chrome's TLD list
69 being out of date, and not an omnibox issue. Such TLD issues should be duped
70 against http://crbug.com/37436.
71 * `Cr-Internals-Media-Network`: Issues related to media. These often run into
72 the 6 requests per hostname issue, and also have fun interactions with the
73 cache, particularly in the range request case.
74 * `Cr-Internals-Plugins-PDF`: Issues loading pdf files. These are often
75 related to range requests, which also have some logic at the
76 Internals-Network-Cache layer.
77 * `Cr-UI-Browser-Navigation`
78 * `Cr-UI-Browser-History`: Issues which only appear with forward/back
79 navigation.
80 * `Cr-OS-Systems-Network` / `Cr-OS-Systems-Mobile` / `Cr-OS-Systems-Bluetooth`:
81 These should be used for issues with ChromeOS's platform network code, and
82 not net/ issues on ChromeOS.
83 * `Cr-Blink-SecurityFeature`: CORS / Cross origin issues. Main frame
84 cross-origin navigation issues are often actually `Cr-UI-Browser-Navigation`
85 issues.
86 * `Cr-Privacy`: Privacy related bug (History, cookies discoverable by an
87 entity that shouldn't be able to do so, incognito state being saved in memory
88 or on disk beyond the lifetime of incognito tabs, etc). Generally used in
89 conjunction with other labels.
90 * `Type-Bug-Security`: Security related bug (Allows for code execution from
91 remote site, allows crossing security boundaries, unchecked array bounds,
92 etc).
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698