Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(380)

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp

Issue 1017733003: [DO NOT LAND] Set @@toStringTag for DOM object prototypes (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: More test rebaselines Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
diff --git a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
index a19fbf95384febbc72f6c63801c9c3a4cdde0651..9ac9e6989ae0a62d3c5b677d5467860b34b1fbe7 100644
--- a/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
+++ b/Source/bindings/tests/results/core/V8TestInterfaceNamedConstructor2.cpp
@@ -73,7 +73,7 @@ v8::Local<v8::FunctionTemplate> V8TestInterfaceNamedConstructor2Constructor::dom
result = v8::FunctionTemplate::New(isolate, V8TestInterfaceNamedConstructor2ConstructorCallback);
v8::Local<v8::ObjectTemplate> instanceTemplate = result->InstanceTemplate();
instanceTemplate->SetInternalFieldCount(V8TestInterfaceNamedConstructor2::internalFieldCount);
- result->SetClassName(v8AtomicString(isolate, "TestInterfaceNamedConstructor2"));
+ instanceTemplate->Set(v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, "TestInterfaceNamedConstructor2"));
result->Inherit(V8TestInterfaceNamedConstructor2::domTemplate(isolate));
data->setDOMTemplate(&domTemplateKey, result);
return result;
@@ -93,6 +93,10 @@ static void installV8TestInterfaceNamedConstructor2Template(v8::Local<v8::Functi
v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();
ALLOW_UNUSED_LOCAL(prototypeTemplate);
+ instanceTemplate->Set(v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, "TestInterfaceNamedConstructor2"));
+
+ prototypeTemplate->Set(v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, "TestInterfaceNamedConstructor2Prototype"));
+
// Custom toString template
functionTemplate->Set(v8AtomicString(isolate, "toString"), V8PerIsolateData::from(isolate)->toStringTemplate());
}

Powered by Google App Engine
This is Rietveld 408576698