Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp - Issue 1017733003: [DO NOT LAND] Set @@toStringTag for DOM object prototypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp

Issue 1017733003: [DO NOT LAND] Set @@toStringTag for DOM object prototypes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: More test rebaselines Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/bindings/templates/interface_base.cpp ('K') | « Source/bindings/tests/results/core/V8TestInterfaceConstructor4.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceDocument.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp b/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp

index 0dce9ea5e341dd30acbc479ad9a0967c2e91b009..9ab125ac790b7c8ff374cd3537b4572de09eaa09 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceCustomConstructor.cpp

@@ -64,6 +64,10 @@ static void installV8TestInterfaceCustomConstructorTemplate(v8::Local<v8::Functi

v8::Local<v8::ObjectTemplate> prototypeTemplate = functionTemplate->PrototypeTemplate();

ALLOW_UNUSED_LOCAL(prototypeTemplate);

+ instanceTemplate->Set(v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, "TestInterfaceCustomConstructor"));

+ prototypeTemplate->Set(v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, "TestInterfaceCustomConstructorPrototype"));

// Custom toString template

functionTemplate->Set(v8AtomicString(isolate, "toString"), V8PerIsolateData::from(isolate)->toStringTemplate());

}