Source/bindings/templates/interface.cpp - Issue 1017733003: [DO NOT LAND] Set @@toStringTag for DOM object prototypes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface.cpp

Issue 1017733003: [DO NOT LAND] Set @@toStringTag for DOM object prototypes (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: More test rebaselines Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/bindings/templates/interface.cpp

diff --git a/Source/bindings/templates/interface.cpp b/Source/bindings/templates/interface.cpp

index a0ca6eba6d1e2bfb5ad1ae786c590e850a61653a..94e95f9ec733b691427919af139df6d88ebfe7ed 100644

--- a/Source/bindings/templates/interface.cpp

+++ b/Source/bindings/templates/interface.cpp

@@ -511,7 +511,7 @@ v8::Local<v8::FunctionTemplate> {{v8_class}}Constructor::domTemplate(v8::Isolate

result = v8::FunctionTemplate::New(isolate, {{v8_class}}ConstructorCallback);

v8::Local<v8::ObjectTemplate> instanceTemplate = result->InstanceTemplate();

instanceTemplate->SetInternalFieldCount({{v8_class}}::internalFieldCount);

- result->SetClassName(v8AtomicString(isolate, "{{cpp_class}}"));

+ instanceTemplate->Set(v8::Symbol::GetToStringTag(isolate), v8AtomicString(isolate, "{{cpp_class}}"));

result->Inherit({{v8_class}}::domTemplate(isolate));

data->setDOMTemplate(&domTemplateKey, result);

return result;