Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(388)

Issue 1017683003: Don't open the Collected Cookies dialog if the related web contents is null because the tab was alr… (Closed)

Created:
5 years, 9 months ago by markusheintz_
Modified:
5 years, 7 months ago
CC:
chromium-reviews, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't open the Collected Cookies dialog if the related web contents is null because the tab was already closed. BUG=434569 Committed: https://crrev.com/56de5c361e59b039c7347441da6fb5f5b8ee32ee Cr-Commit-Position: refs/heads/master@{#329969}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/ui/views/website_settings/website_settings_popup_view.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
markusheintz_
Martin could you please review my CL? Thanks
5 years, 9 months ago (2015-03-17 13:34:35 UTC) #2
msramek
On 2015/03/17 13:34:35, markusheintz_ wrote: > Martin could you please review my CL? Thanks As ...
5 years, 9 months ago (2015-03-17 13:53:17 UTC) #3
msramek
As discussed online again: let's not complicate it. LGTM.
5 years, 9 months ago (2015-03-17 17:35:48 UTC) #4
markusheintz_
On 2015/03/17 17:35:48, msramek wrote: > As discussed online again: let's not complicate it. > ...
5 years, 9 months ago (2015-03-17 17:39:18 UTC) #6
Will Harris
lgtm sorry for delay
5 years, 9 months ago (2015-03-21 21:00:01 UTC) #7
Will Harris
can this be committed?
5 years, 7 months ago (2015-05-03 22:05:18 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017683003/1
5 years, 7 months ago (2015-05-14 22:13:39 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-14 23:11:44 UTC) #11
commit-bot: I haz the power
5 years, 7 months ago (2015-05-14 23:13:31 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/56de5c361e59b039c7347441da6fb5f5b8ee32ee
Cr-Commit-Position: refs/heads/master@{#329969}

Powered by Google App Engine
This is Rietveld 408576698