Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 1017673002: Flexbox: negatively stretching a flexbox should have border + padding as a minimum (Closed)

Created:
5 years, 9 months ago by rhogan
Modified:
5 years, 8 months ago
CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Flexbox: negatively stretching a flexbox should have border + padding as a minimum When stretching on the cross axis ends up compressing the box to fit within the container then do not allow the compression to reduce the height of the box beyond its border and padding. BUG=380201 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193720

Patch Set 1 #

Patch Set 2 : Updated #

Patch Set 3 : Updated #

Total comments: 1

Patch Set 4 : Updated #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
A LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space-assert.html View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space-assert-expected.txt View 1 2 3 1 chunk +6 lines, -0 lines 0 comments Download
M Source/core/layout/LayoutFlexibleBox.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
rhogan
HI Christian - can you take a look?
5 years, 8 months ago (2015-04-13 20:46:20 UTC) #2
cbiesinger
lgtm, but please change the testcase description to say assert instead of crash.
5 years, 8 months ago (2015-04-13 20:52:37 UTC) #3
cbiesinger
https://codereview.chromium.org/1017673002/diff/40001/LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space-crash-expected.txt File LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space-crash-expected.txt (right): https://codereview.chromium.org/1017673002/diff/40001/LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space-crash-expected.txt#newcode5 LayoutTests/css3/flexbox/flex-flow-auto-margins-no-available-space-crash-expected.txt:5: if (window.testRunner) testRunner.dumpAsText(); Actually can you make this a ...
5 years, 8 months ago (2015-04-13 20:54:05 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017673002/60001
5 years, 8 months ago (2015-04-13 21:11:40 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/31144)
5 years, 8 months ago (2015-04-13 23:56:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017673002/60001
5 years, 8 months ago (2015-04-14 07:33:25 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/31180)
5 years, 8 months ago (2015-04-14 07:39:38 UTC) #13
cbiesinger
Oh... you're not an owner? Neither am I :)
5 years, 8 months ago (2015-04-14 18:10:04 UTC) #14
rhogan
@leviw - mind rubber-stamping this one?
5 years, 8 months ago (2015-04-14 18:12:23 UTC) #16
pdr.
On 2015/04/14 at 18:10:04, cbiesinger wrote: > Oh... you're not an owner? Neither am I ...
5 years, 8 months ago (2015-04-14 18:12:38 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017673002/60001
5 years, 8 months ago (2015-04-14 18:13:34 UTC) #19
leviw_travelin_and_unemployed
On 2015/04/14 at 18:12:38, pdr wrote: > On 2015/04/14 at 18:10:04, cbiesinger wrote: > > ...
5 years, 8 months ago (2015-04-14 18:13:47 UTC) #20
commit-bot: I haz the power
5 years, 8 months ago (2015-04-14 18:29:00 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193720

Powered by Google App Engine
This is Rietveld 408576698