Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 1017663003: Adds Ash.StationaryTouchDuration to histograms.xml (Closed)

Created:
5 years, 9 months ago by pkotwicz
Modified:
5 years, 9 months ago
Reviewers:
sadrul, Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Adds Ash.StationaryTouchDuration to histograms.xml BUG=465751 TEST=None Committed: https://crrev.com/bfe8469295007b95bf14004ae0b295430091f08a Cr-Commit-Position: refs/heads/master@{#321204}

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -5 lines) Patch
M tools/metrics/histograms/histograms.xml View 3 chunks +10 lines, -5 lines 0 comments Download

Messages

Total messages: 17 (7 generated)
pkotwicz
Sadrul, PTAL This was the only Ash histogram which is missing from histograms.xml
5 years, 9 months ago (2015-03-17 21:51:50 UTC) #3
sadrul
https://codereview.chromium.org/1017663003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1017663003/diff/20001/tools/metrics/histograms/histograms.xml#newcode690 tools/metrics/histograms/histograms.xml:690: + <owner>sadrul@chromium.org</owner> rbyers@
5 years, 9 months ago (2015-03-17 21:55:26 UTC) #4
pkotwicz
Sadrul, can you please take another look? https://codereview.chromium.org/1017663003/diff/20001/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/1017663003/diff/20001/tools/metrics/histograms/histograms.xml#newcode690 tools/metrics/histograms/histograms.xml:690: + <owner>sadrul@chromium.org</owner> ...
5 years, 9 months ago (2015-03-17 22:15:05 UTC) #6
sadrul
lgtm (not sure why this needs my review though; rbyers@ would be more appropriate)
5 years, 9 months ago (2015-03-17 22:18:21 UTC) #7
pkotwicz
isherman@ for OWNERS
5 years, 9 months ago (2015-03-18 17:40:21 UTC) #9
Ilya Sherman
histograms.xml lgtm. For future CLs, please include histograms.xml changes along with the C++ changes, if ...
5 years, 9 months ago (2015-03-18 18:26:39 UTC) #10
Ilya Sherman
From clicking through to the bug, I see that you're adding histograms that were omitted ...
5 years, 9 months ago (2015-03-18 18:28:27 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017663003/100001
5 years, 9 months ago (2015-03-18 18:56:02 UTC) #15
commit-bot: I haz the power
Committed patchset #3 (id:100001)
5 years, 9 months ago (2015-03-18 21:15:22 UTC) #16
commit-bot: I haz the power
5 years, 9 months ago (2015-03-18 21:16:00 UTC) #17
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/bfe8469295007b95bf14004ae0b295430091f08a
Cr-Commit-Position: refs/heads/master@{#321204}

Powered by Google App Engine
This is Rietveld 408576698