Issue 1017663002: add missing dcheck to ToLocalChecked

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1017663002: add missing dcheck to ToLocalChecked (Closed)

Created:
5 years, 9 months ago by dcarney

Modified:
5 years, 9 months ago

Reviewers:
Sven Panne

CC:
v8-dev, Paweł Hajdan Jr.

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

add missing dcheck to ToLocalChecked R=svenpanne@chromium.org BUG=v8:3929 LOG=n Committed: https://crrev.com/4a99e6f49308c1294a60a1e879f063af6d952f8c Cr-Commit-Position: refs/heads/master@{#27229}

Created: 5 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+18 lines, -4 lines)			Patch
	M	include/v8.h	View		3 chunks	+13 lines, -4 lines	0 comments	Download
	M	src/api.cc	View		1 chunk	+5 lines, -0 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017663002/1

5 years, 9 months ago (2015-03-17 08:23:54 UTC) #4

commit-bot: I haz the power

5 years, 9 months ago (2015-03-17 09:04:00 UTC) #6

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/4a99e6f49308c1294a60a1e879f063af6d952f8c
Cr-Commit-Position: refs/heads/master@{#27229}