FileVideoCaptureDevice: better error mgmt if !File.IsValid()

media/video/capture/file_video_capture_device_factory.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "media/video/capture/file_video_capture_device_factory.h"
 
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/strings/sys_string_conversions.h"
 #include "media/base/media_switches.h"
@@ skipping 22 matching lines @@
 #else
   return scoped_ptr<VideoCaptureDevice>(new FileVideoCaptureDevice(
       base::FilePath(device_name.name())));
 #endif
 }
 
 void FileVideoCaptureDeviceFactory::GetDeviceNames(
     VideoCaptureDevice::Names* const device_names) {
   DCHECK(thread_checker_.CalledOnValidThread());
   DCHECK(device_names->empty());
-  base::FilePath command_line_file_path = GetFilePathFromCommandLine();
+  const base::FilePath command_line_file_path = GetFilePathFromCommandLine();
 #if defined(OS_WIN)
   device_names->push_back(VideoCaptureDevice::Name(
       base::SysWideToUTF8(command_line_file_path.value()),
       kFileVideoCaptureDeviceName,
       VideoCaptureDevice::Name::DIRECT_SHOW));
 #elif defined(OS_MACOSX)
   device_names->push_back(VideoCaptureDevice::Name(
       command_line_file_path.value(),
       kFileVideoCaptureDeviceName,
       VideoCaptureDevice::Name::AVFOUNDATION));
 #else
   device_names->push_back(VideoCaptureDevice::Name(
       command_line_file_path.value(),
       kFileVideoCaptureDeviceName));
 #endif
 }
 
 void FileVideoCaptureDeviceFactory::GetDeviceSupportedFormats(
     const VideoCaptureDevice::Name& device,
     VideoCaptureFormats* supported_formats) {
   DCHECK(thread_checker_.CalledOnValidThread());
   base::File file =
       FileVideoCaptureDevice::OpenFileForRead(GetFilePathFromCommandLine());
+  if (!file.IsValid())
+    return;
   VideoCaptureFormat capture_format;
   FileVideoCaptureDevice::ParseFileAndExtractVideoFormat(&file,
                                                          &capture_format);
   supported_formats->push_back(capture_format);
 }
 
 }  // namespace media