Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 101763010: Fix build warnings in SkAlphaThresholdFilter (Closed)

Created:
6 years, 11 months ago by Zachary Kuznia
Modified:
6 years, 11 months ago
Reviewers:
bsalomon
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Fix build warnings in SkAlphaThresholdFilter BUG=None Committed: http://code.google.com/p/skia/source/detail?r=12937

Patch Set 1 #

Patch Set 2 : Fix another warning #

Patch Set 3 : Fix another warning #

Patch Set 4 : Fix another warning #

Patch Set 5 : Fix another warning #

Patch Set 6 : Fix another warning #

Patch Set 7 : Fix another warning #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M gm/imagealphathreshold.cpp View 1 2 3 4 5 6 1 chunk +1 line, -1 line 0 comments Download
M src/effects/SkAlphaThresholdFilter.cpp View 1 2 3 4 3 chunks +13 lines, -13 lines 0 comments Download
M tests/GLProgramsTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (0 generated)
Zachary Kuznia
Hi Brian, Please take a look at this. It should fix the broken builds on ...
6 years, 11 months ago (2014-01-07 02:00:48 UTC) #1
bsalomon
lgtm
6 years, 11 months ago (2014-01-07 15:20:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/zork@chromium.org/101763010/210001
6 years, 11 months ago (2014-01-07 15:21:01 UTC) #3
mtklein
On 2014/01/07 15:21:01, I haz the power (commit-bot) wrote: > CQ is trying da patch. ...
6 years, 11 months ago (2014-01-07 15:27:06 UTC) #4
commit-bot: I haz the power
Change committed as 12937
6 years, 11 months ago (2014-01-07 16:04:10 UTC) #5
mtklein
On 2014/01/07 16:04:10, I haz the power (commit-bot) wrote: > Change committed as 12937 GM ...
6 years, 11 months ago (2014-01-07 17:02:27 UTC) #6
bsalomon
6 years, 11 months ago (2014-01-07 17:05:12 UTC) #7
Message was sent while issue was closed.
On 2014/01/07 17:02:27, mtklein wrote:
> On 2014/01/07 16:04:10, I haz the power (commit-bot) wrote:
> > Change committed as 12937
> 
> GM is also failing on the bots for the same reason.

I'll exclude it until we have a fix.

Powered by Google App Engine
This is Rietveld 408576698