Source/core/editing/CompositeEditCommand.cpp - Issue 101763008: Fix some problems reported by clang static analyzer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/CompositeEditCommand.cpp

Issue 101763008: Fix some problems reported by clang static analyzer (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/CompositeEditCommand.cpp

diff --git a/Source/core/editing/CompositeEditCommand.cpp b/Source/core/editing/CompositeEditCommand.cpp

index 20c6ca62f0b1df163c48b7c4be6c5a3ee810d785..f4e5882d405e1ba72eb7484d4c339d5f452e8d85 100644

--- a/Source/core/editing/CompositeEditCommand.cpp

+++ b/Source/core/editing/CompositeEditCommand.cpp

@@ -790,7 +790,6 @@ void CompositeEditCommand::deleteInsignificantText(PassRefPtr<Text> textNode, un

int gapLen = gapEnd - gapStart;

if (indicesIntersect && gapLen > 0) {

gapStart = max(gapStart, start);

- gapEnd = min(gapEnd, end);

if (str.isNull())

str = textNode->data().substring(start, end - start);

// remove text in the gap

« no previous file with comments | « Source/core/editing/ApplyStyleCommand.cpp ('k') | Source/core/editing/markup.cpp » ('j') | no next file with comments »