Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(468)

Unified Diff: test/cctest/test-parsing.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reupload to make rietveld happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-regexp.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/cctest/test-parsing.cc
diff --git a/test/cctest/test-parsing.cc b/test/cctest/test-parsing.cc
index 89a1e5b086c58a22833e4a4c13f532bd8e1453f1..e53250def93322a9e965ac0b2be1455856375e47 100644
--- a/test/cctest/test-parsing.cc
+++ b/test/cctest/test-parsing.cc
@@ -390,13 +390,13 @@ TEST(PreParseOverflow) {
size_t kProgramSize = 1024 * 1024;
i::SmartArrayPointer<char> program(i::NewArray<char>(kProgramSize + 1));
- memset(*program, '(', kProgramSize);
+ memset(program.get(), '(', kProgramSize);
program[kProgramSize] = '\0';
uintptr_t stack_limit = CcTest::i_isolate()->stack_guard()->real_climit();
i::Utf8ToUtf16CharacterStream stream(
- reinterpret_cast<const i::byte*>(*program),
+ reinterpret_cast<const i::byte*>(program.get()),
static_cast<unsigned>(kProgramSize));
i::CompleteParserRecorder log;
i::Scanner scanner(CcTest::i_isolate()->unicode_cache());
@@ -447,7 +447,7 @@ void TestCharacterStream(const char* ascii_source,
i::Vector<const char> ascii_vector(ascii_source, static_cast<int>(length));
i::Handle<i::String> ascii_string(
factory->NewStringFromAscii(ascii_vector));
- TestExternalResource resource(*uc16_buffer, length);
+ TestExternalResource resource(uc16_buffer.get(), length);
i::Handle<i::String> uc16_string(
factory->NewExternalStringFromTwoByte(&resource));
@@ -1152,7 +1152,7 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
"with error:\n"
"\t%s\n"
"However, the preparser succeeded",
- *source->ToCString(), *message_string->ToCString());
+ source->ToCString().get(), message_string->ToCString().get());
CHECK(false);
}
// Check that preparser and parser produce the same error.
@@ -1164,9 +1164,9 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
"However, found the following error messages\n"
"\tparser: %s\n"
"\tpreparser: %s\n",
- *source->ToCString(),
- *message_string->ToCString(),
- *preparser_message->ToCString());
+ source->ToCString().get(),
+ message_string->ToCString().get(),
+ preparser_message->ToCString().get());
CHECK(false);
}
} else if (data.has_error()) {
@@ -1176,7 +1176,7 @@ void TestParserSyncWithFlags(i::Handle<i::String> source,
"with error:\n"
"\t%s\n"
"However, the parser succeeded",
- *source->ToCString(), *FormatMessage(&data)->ToCString());
+ source->ToCString().get(), FormatMessage(&data)->ToCString().get());
CHECK(false);
}
}
« no previous file with comments | « test/cctest/test-heap-profiler.cc ('k') | test/cctest/test-regexp.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698