test/cctest/test-heap-profiler.cc - Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/cctest/test-heap-profiler.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Reupload to make rietveld happy Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: test/cctest/test-heap-profiler.cc

diff --git a/test/cctest/test-heap-profiler.cc b/test/cctest/test-heap-profiler.cc

index eff5744d83543664cc10f09a49b98f862fc08bea..5c7d9d8f58d2e06432e9a4d2cc2284cd9df5cab1 100644

--- a/test/cctest/test-heap-profiler.cc

+++ b/test/cctest/test-heap-profiler.cc

@@ -1581,9 +1581,9 @@ TEST(GetHeapValueForDeletedObject) {

static int StringCmp(const char* ref, i::String* act) {

i::SmartArrayPointer<char> s_act = act->ToCString();

- int result = strcmp(ref, *s_act);

+ int result = strcmp(ref, s_act.get());

if (result != 0)

- fprintf(stderr, "Expected: \"%s\", Actual: \"%s\"\n", ref, *s_act);

+ fprintf(stderr, "Expected: \"%s\", Actual: \"%s\"\n", ref, s_act.get());

return result;

}

« no previous file with comments | « test/cctest/test-func-name-inference.cc ('k') | test/cctest/test-parsing.cc » ('j') | no next file with comments »