src/objects.cc - Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/objects.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Reupload to make rietveld happy Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/objects.cc

diff --git a/src/objects.cc b/src/objects.cc

index f96fd83849cff3090814484757f26b352932bc87..43a047e78c0cd80c179a3c476c919f6251475362 100644

--- a/src/objects.cc

+++ b/src/objects.cc

@@ -1683,7 +1683,7 @@ void HeapObject::HeapObjectShortPrint(StringStream* accumulator) {

SmartArrayPointer<char> debug_name =

shared->DebugName()->ToCString();

if (debug_name[0] != 0) {

- accumulator->Add("<SharedFunctionInfo %s>", *debug_name);

+ accumulator->Add("<SharedFunctionInfo %s>", debug_name.get());

} else {

accumulator->Add("<SharedFunctionInfo>");

}

@@ -9913,7 +9913,7 @@ void JSFunction::SetInstanceClassName(String* name) {

void JSFunction::PrintName(FILE* out) {

SmartArrayPointer<char> name = shared()->DebugName()->ToCString();

- PrintF(out, "%s", *name);

+ PrintF(out, "%s", name.get());

}

« no previous file with comments | « src/mips/lithium-mips.cc ('k') | src/objects-printer.cc » ('j') | no next file with comments »