src/disassembler.cc - Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/disassembler.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Reupload to make rietveld happy Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/disassembler.cc

diff --git a/src/disassembler.cc b/src/disassembler.cc

index 69737ed89f8b6bbf0649dc61ba16285cf6a2f9f4..8bec2ced32db5a3325277b696982c46da9517f79 100644

--- a/src/disassembler.cc

+++ b/src/disassembler.cc

@@ -224,7 +224,7 @@ static int DecodeIt(Isolate* isolate,

StringStream accumulator(&allocator);

relocinfo.target_object()->ShortPrint(&accumulator);

SmartArrayPointer<const char> obj_name = accumulator.ToCString();

- out.AddFormatted(" ;; object: %s", *obj_name);

+ out.AddFormatted(" ;; object: %s", obj_name.get());

} else if (rmode == RelocInfo::EXTERNAL_REFERENCE) {

const char* reference_name =

ref_encoder.NameOfAddress(relocinfo.target_reference());

« no previous file with comments | « src/deoptimizer.cc ('k') | src/factory.cc » ('j') | no next file with comments »