Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Unified Diff: src/compiler.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reupload to make rietveld happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/codegen.cc ('k') | src/d8-debug.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler.cc
diff --git a/src/compiler.cc b/src/compiler.cc
index 83f9ab2daffb78830e80a50e4aefe2aa171af624..3aadbc2ef5fc859499eae7f3b5406bbd2de0760f 100644
--- a/src/compiler.cc
+++ b/src/compiler.cc
@@ -460,7 +460,7 @@ RecompileJob::Status RecompileJob::CreateGraph() {
if (FLAG_trace_hydrogen) {
Handle<String> name = info()->function()->debug_name();
PrintF("-----------------------------------------------------------\n");
- PrintF("Compiling method %s using hydrogen\n", *name->ToCString());
+ PrintF("Compiling method %s using hydrogen\n", name->ToCString().get());
isolate()->GetHTracer()->TraceCompilation(info());
}
@@ -1100,20 +1100,20 @@ bool Compiler::RecompileConcurrent(Handle<JSFunction> closure,
isolate->counters()->total_compile_size()->Increment(compiled_size);
{
- CompilationHandleScope handle_scope(*info);
+ CompilationHandleScope handle_scope(info.get());
- if (!compiling_for_osr && InstallCodeFromOptimizedCodeMap(*info)) {
+ if (!compiling_for_osr && InstallCodeFromOptimizedCodeMap(info.get())) {
return true;
}
- if (Parser::Parse(*info)) {
+ if (Parser::Parse(info.get())) {
LanguageMode language_mode = info->function()->language_mode();
info->SetLanguageMode(language_mode);
shared->set_language_mode(language_mode);
info->SaveHandles();
- if (Rewriter::Rewrite(*info) && Scope::Analyze(*info)) {
- RecompileJob* job = new(info->zone()) RecompileJob(*info);
+ if (Rewriter::Rewrite(info.get()) && Scope::Analyze(info.get())) {
+ RecompileJob* job = new(info->zone()) RecompileJob(info.get());
RecompileJob::Status status = job->CreateGraph();
if (status == RecompileJob::SUCCEEDED) {
info.Detach();
@@ -1123,7 +1123,7 @@ bool Compiler::RecompileConcurrent(Handle<JSFunction> closure,
return true;
} else if (status == RecompileJob::BAILED_OUT) {
isolate->clear_pending_exception();
- InstallFullCode(*info);
+ InstallFullCode(info.get());
}
}
}
@@ -1140,7 +1140,7 @@ Handle<Code> Compiler::InstallOptimizedCode(RecompileJob* job) {
// Except when OSR already disabled optimization for some reason.
if (info->shared_info()->optimization_disabled()) {
info->AbortOptimization();
- InstallFullCode(*info);
+ InstallFullCode(info.get());
if (FLAG_trace_concurrent_recompilation) {
PrintF(" ** aborting optimization for ");
info->closure()->PrintName();
@@ -1172,14 +1172,14 @@ Handle<Code> Compiler::InstallOptimizedCode(RecompileJob* job) {
status == RecompileJob::BAILED_OUT);
}
- InstallCodeCommon(*info);
+ InstallCodeCommon(info.get());
if (status == RecompileJob::SUCCEEDED) {
Handle<Code> code = info->code();
ASSERT(info->shared_info()->scope_info() != ScopeInfo::Empty(isolate));
info->closure()->ReplaceCode(*code);
if (info->shared_info()->SearchOptimizedCodeMap(
info->closure()->context()->native_context()) == -1) {
- InsertCodeIntoOptimizedCodeMap(*info);
+ InsertCodeIntoOptimizedCodeMap(info.get());
}
if (FLAG_trace_concurrent_recompilation) {
PrintF(" ** Optimized code for ");
@@ -1188,7 +1188,7 @@ Handle<Code> Compiler::InstallOptimizedCode(RecompileJob* job) {
}
} else {
info->AbortOptimization();
- InstallFullCode(*info);
+ InstallFullCode(info.get());
}
// Optimized code is finally replacing unoptimized code. Reset the latter's
// profiler ticks to prevent too soon re-opt after a deopt.
« no previous file with comments | « src/codegen.cc ('k') | src/d8-debug.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698