src/heap-snapshot-generator.cc - Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap-snapshot-generator.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap-snapshot-generator.cc

diff --git a/src/heap-snapshot-generator.cc b/src/heap-snapshot-generator.cc

index 84e819d7a6d08a1d9ec4c846b1a17952f57f80ac..8bf3d76da67c9161686fd2137141c64ad42b4371 100644

--- a/src/heap-snapshot-generator.cc

+++ b/src/heap-snapshot-generator.cc

@@ -1854,8 +1854,8 @@ void V8HeapExplorer::SetPropertyReference(HeapObject* parent_obj,

const char* name = name_format_string != NULL && reference_name->IsString()

? names_->GetFormatted(

name_format_string,

- *String::cast(reference_name)->ToCString(

- DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL)) :

+ String::cast(reference_name)->ToCString(

+ DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL).get()) :

names_->GetName(reference_name);

filler_->SetNamedReference(type,

« no previous file with comments | « src/heap-profiler.cc ('k') | src/hydrogen.cc » ('j') | src/smart-pointers.h » ('J')