Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Side by Side Diff: src/heap-snapshot-generator.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reupload to make rietveld happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/heap-profiler.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1836 matching lines...) Expand 10 before | Expand all | Expand 10 after
1847 int field_offset) { 1847 int field_offset) {
1848 ASSERT(parent_entry == GetEntry(parent_obj)->index()); 1848 ASSERT(parent_entry == GetEntry(parent_obj)->index());
1849 HeapEntry* child_entry = GetEntry(child_obj); 1849 HeapEntry* child_entry = GetEntry(child_obj);
1850 if (child_entry != NULL) { 1850 if (child_entry != NULL) {
1851 HeapGraphEdge::Type type = 1851 HeapGraphEdge::Type type =
1852 reference_name->IsSymbol() || String::cast(reference_name)->length() > 0 1852 reference_name->IsSymbol() || String::cast(reference_name)->length() > 0
1853 ? HeapGraphEdge::kProperty : HeapGraphEdge::kInternal; 1853 ? HeapGraphEdge::kProperty : HeapGraphEdge::kInternal;
1854 const char* name = name_format_string != NULL && reference_name->IsString() 1854 const char* name = name_format_string != NULL && reference_name->IsString()
1855 ? names_->GetFormatted( 1855 ? names_->GetFormatted(
1856 name_format_string, 1856 name_format_string,
1857 *String::cast(reference_name)->ToCString( 1857 String::cast(reference_name)->ToCString(
1858 DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL)) : 1858 DISALLOW_NULLS, ROBUST_STRING_TRAVERSAL).get()) :
1859 names_->GetName(reference_name); 1859 names_->GetName(reference_name);
1860 1860
1861 filler_->SetNamedReference(type, 1861 filler_->SetNamedReference(type,
1862 parent_entry, 1862 parent_entry,
1863 name, 1863 name,
1864 child_entry); 1864 child_entry);
1865 IndexedReferencesExtractor::MarkVisitedField(parent_obj, field_offset); 1865 IndexedReferencesExtractor::MarkVisitedField(parent_obj, field_offset);
1866 } 1866 }
1867 } 1867 }
1868 1868
(...skipping 1085 matching lines...) Expand 10 before | Expand all | Expand 10 after
2954 writer_->AddString("\"<dummy>\""); 2954 writer_->AddString("\"<dummy>\"");
2955 for (int i = 1; i < sorted_strings.length(); ++i) { 2955 for (int i = 1; i < sorted_strings.length(); ++i) {
2956 writer_->AddCharacter(','); 2956 writer_->AddCharacter(',');
2957 SerializeString(sorted_strings[i]); 2957 SerializeString(sorted_strings[i]);
2958 if (writer_->aborted()) return; 2958 if (writer_->aborted()) return;
2959 } 2959 }
2960 } 2960 }
2961 2961
2962 2962
2963 } } // namespace v8::internal 2963 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/heap-profiler.cc ('k') | src/hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698