Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: src/disassembler.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reupload to make rietveld happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/deoptimizer.cc ('k') | src/factory.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2011 the V8 project authors. All rights reserved. 1 // Copyright 2011 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 206 matching lines...) Expand 10 before | Expand all | Expand 10 after
217 if (RelocInfo::IsStatementPosition(rmode)) { 217 if (RelocInfo::IsStatementPosition(rmode)) {
218 out.AddFormatted(" ;; debug: statement %d", relocinfo.data()); 218 out.AddFormatted(" ;; debug: statement %d", relocinfo.data());
219 } else { 219 } else {
220 out.AddFormatted(" ;; debug: position %d", relocinfo.data()); 220 out.AddFormatted(" ;; debug: position %d", relocinfo.data());
221 } 221 }
222 } else if (rmode == RelocInfo::EMBEDDED_OBJECT) { 222 } else if (rmode == RelocInfo::EMBEDDED_OBJECT) {
223 HeapStringAllocator allocator; 223 HeapStringAllocator allocator;
224 StringStream accumulator(&allocator); 224 StringStream accumulator(&allocator);
225 relocinfo.target_object()->ShortPrint(&accumulator); 225 relocinfo.target_object()->ShortPrint(&accumulator);
226 SmartArrayPointer<const char> obj_name = accumulator.ToCString(); 226 SmartArrayPointer<const char> obj_name = accumulator.ToCString();
227 out.AddFormatted(" ;; object: %s", *obj_name); 227 out.AddFormatted(" ;; object: %s", obj_name.get());
228 } else if (rmode == RelocInfo::EXTERNAL_REFERENCE) { 228 } else if (rmode == RelocInfo::EXTERNAL_REFERENCE) {
229 const char* reference_name = 229 const char* reference_name =
230 ref_encoder.NameOfAddress(relocinfo.target_reference()); 230 ref_encoder.NameOfAddress(relocinfo.target_reference());
231 out.AddFormatted(" ;; external reference (%s)", reference_name); 231 out.AddFormatted(" ;; external reference (%s)", reference_name);
232 } else if (RelocInfo::IsCodeTarget(rmode)) { 232 } else if (RelocInfo::IsCodeTarget(rmode)) {
233 out.AddFormatted(" ;; code:"); 233 out.AddFormatted(" ;; code:");
234 if (rmode == RelocInfo::CONSTRUCT_CALL) { 234 if (rmode == RelocInfo::CONSTRUCT_CALL) {
235 out.AddFormatted(" constructor,"); 235 out.AddFormatted(" constructor,");
236 } 236 }
237 Code* code = Code::GetCodeFromTargetAddress(relocinfo.target_address()); 237 Code* code = Code::GetCodeFromTargetAddress(relocinfo.target_address());
(...skipping 122 matching lines...) Expand 10 before | Expand all | Expand 10 after
360 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) { 360 int Disassembler::Decode(Isolate* isolate, FILE* f, byte* begin, byte* end) {
361 return 0; 361 return 0;
362 } 362 }
363 363
364 364
365 void Disassembler::Decode(FILE* f, Code* code) {} 365 void Disassembler::Decode(FILE* f, Code* code) {}
366 366
367 #endif // ENABLE_DISASSEMBLER 367 #endif // ENABLE_DISASSEMBLER
368 368
369 } } // namespace v8::internal 369 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/deoptimizer.cc ('k') | src/factory.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698