Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: src/d8-debug.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reupload to make rietveld happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/d8-debug.h ('k') | src/debug-agent.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 314 matching lines...) Expand 10 before | Expand all | Expand 10 after
325 325
326 // Send the JSON debugger request. 326 // Send the JSON debugger request.
327 i::DebuggerAgentUtil::SendMessage(conn_, Handle<String>::Cast(request)); 327 i::DebuggerAgentUtil::SendMessage(conn_, Handle<String>::Cast(request));
328 } 328 }
329 329
330 330
331 void ReceiverThread::Run() { 331 void ReceiverThread::Run() {
332 // Receive the connect message (with empty body). 332 // Receive the connect message (with empty body).
333 i::SmartArrayPointer<char> message = 333 i::SmartArrayPointer<char> message =
334 i::DebuggerAgentUtil::ReceiveMessage(remote_debugger_->conn()); 334 i::DebuggerAgentUtil::ReceiveMessage(remote_debugger_->conn());
335 ASSERT(*message == NULL); 335 ASSERT(message.get() == NULL);
336 336
337 while (true) { 337 while (true) {
338 // Receive a message. 338 // Receive a message.
339 i::SmartArrayPointer<char> message = 339 i::SmartArrayPointer<char> message =
340 i::DebuggerAgentUtil::ReceiveMessage(remote_debugger_->conn()); 340 i::DebuggerAgentUtil::ReceiveMessage(remote_debugger_->conn());
341 if (*message == NULL) { 341 if (message.get() == NULL) {
342 remote_debugger_->ConnectionClosed(); 342 remote_debugger_->ConnectionClosed();
343 return; 343 return;
344 } 344 }
345 345
346 // Pass the message to the main thread. 346 // Pass the message to the main thread.
347 remote_debugger_->MessageReceived(message); 347 remote_debugger_->MessageReceived(message);
348 } 348 }
349 } 349 }
350 350
351 351
(...skipping 10 matching lines...) Expand all
362 // Pass the keyboard command to the main thread. 362 // Pass the keyboard command to the main thread.
363 remote_debugger_->KeyboardCommand( 363 remote_debugger_->KeyboardCommand(
364 i::SmartArrayPointer<char>(i::StrDup(command))); 364 i::SmartArrayPointer<char>(i::StrDup(command)));
365 } 365 }
366 } 366 }
367 367
368 368
369 } // namespace v8 369 } // namespace v8
370 370
371 #endif // ENABLE_DEBUGGER_SUPPORT 371 #endif // ENABLE_DEBUGGER_SUPPORT
OLDNEW
« no previous file with comments | « src/d8-debug.h ('k') | src/debug-agent.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698