Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1435)

Side by Side Diff: src/code-stubs.cc

Issue 101763003: Replace 'operator*' with explicit 'get' method on SmartPointer (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Reupload to make rietveld happy Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
73 NoAllocationStringAllocator allocator(buffer, 73 NoAllocationStringAllocator allocator(buffer,
74 static_cast<unsigned>(sizeof(buffer))); 74 static_cast<unsigned>(sizeof(buffer)));
75 StringStream stream(&allocator); 75 StringStream stream(&allocator);
76 PrintName(&stream); 76 PrintName(&stream);
77 return stream.ToCString(); 77 return stream.ToCString();
78 } 78 }
79 79
80 80
81 void CodeStub::RecordCodeGeneration(Code* code, Isolate* isolate) { 81 void CodeStub::RecordCodeGeneration(Code* code, Isolate* isolate) {
82 SmartArrayPointer<const char> name = GetName(); 82 SmartArrayPointer<const char> name = GetName();
83 PROFILE(isolate, CodeCreateEvent(Logger::STUB_TAG, code, *name)); 83 PROFILE(isolate, CodeCreateEvent(Logger::STUB_TAG, code, name.get()));
84 GDBJIT(AddCode(GDBJITInterface::STUB, *name, code)); 84 GDBJIT(AddCode(GDBJITInterface::STUB, name.get(), code));
85 Counters* counters = isolate->counters(); 85 Counters* counters = isolate->counters();
86 counters->total_stubs_code_size()->Increment(code->instruction_size()); 86 counters->total_stubs_code_size()->Increment(code->instruction_size());
87 } 87 }
88 88
89 89
90 Code::Kind CodeStub::GetCodeKind() const { 90 Code::Kind CodeStub::GetCodeKind() const {
91 return Code::STUB; 91 return Code::STUB;
92 } 92 }
93 93
94 94
(...skipping 62 matching lines...) Expand 10 before | Expand all | Expand 10 after
157 HandleScope scope(isolate); 157 HandleScope scope(isolate);
158 158
159 Handle<Code> new_object = GenerateCode(isolate); 159 Handle<Code> new_object = GenerateCode(isolate);
160 new_object->set_major_key(MajorKey()); 160 new_object->set_major_key(MajorKey());
161 FinishCode(new_object); 161 FinishCode(new_object);
162 RecordCodeGeneration(*new_object, isolate); 162 RecordCodeGeneration(*new_object, isolate);
163 163
164 #ifdef ENABLE_DISASSEMBLER 164 #ifdef ENABLE_DISASSEMBLER
165 if (FLAG_print_code_stubs) { 165 if (FLAG_print_code_stubs) {
166 CodeTracer::Scope trace_scope(isolate->GetCodeTracer()); 166 CodeTracer::Scope trace_scope(isolate->GetCodeTracer());
167 new_object->Disassemble(*GetName(), trace_scope.file()); 167 new_object->Disassemble(GetName().get(), trace_scope.file());
168 PrintF(trace_scope.file(), "\n"); 168 PrintF(trace_scope.file(), "\n");
169 } 169 }
170 #endif 170 #endif
171 171
172 if (UseSpecialCache()) { 172 if (UseSpecialCache()) {
173 AddToSpecialCache(new_object); 173 AddToSpecialCache(new_object);
174 } else { 174 } else {
175 // Update the dictionary and the root in Heap. 175 // Update the dictionary and the root in Heap.
176 Handle<UnseededNumberDictionary> dict = 176 Handle<UnseededNumberDictionary> dict =
177 factory->DictionaryAtNumberPut( 177 factory->DictionaryAtNumberPut(
(...skipping 584 matching lines...) Expand 10 before | Expand all | Expand 10 after
762 InstallDescriptor(isolate, &stub3); 762 InstallDescriptor(isolate, &stub3);
763 } 763 }
764 764
765 InternalArrayConstructorStub::InternalArrayConstructorStub( 765 InternalArrayConstructorStub::InternalArrayConstructorStub(
766 Isolate* isolate) { 766 Isolate* isolate) {
767 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate); 767 InternalArrayConstructorStubBase::GenerateStubsAheadOfTime(isolate);
768 } 768 }
769 769
770 770
771 } } // namespace v8::internal 771 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/arm/lithium-arm.cc ('k') | src/code-stubs-hydrogen.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698