Issue 101763002: Make squash commits step more pythony in push-to-trunk script.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 101763002: Make squash commits step more pythony in push-to-trunk script. (Closed)

Created:
7 years ago by Michael Achenbach

Modified:
7 years ago

Reviewers:
ulan

CC:
v8-dev, Jakob Kummerow

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make squash commits step more pythony in push-to-trunk script. Get rid of linux-only shell commands. Solve issue with quotation marks in commit messages. Further behavioral change: Strip white space on line endings. Strip trailing new lines. Test=python -m unittest test_scripts R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18305

Patch Set 1 : #

Patch Set 2 : Rebase. #

Created: 7 years ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+48 lines, -38 lines)			Patch
	M	tools/push-to-trunk/push_to_trunk.py	View	1	1 chunk	+12 lines, -24 lines	0 comments	Download
	M	tools/push-to-trunk/test_scripts.py	View	1	2 chunks	+36 lines, -14 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #2 manually as r18305.

Expand Messages | Collapse Messages