Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1017623003: Add return statement to LinuxCapabilityToKernelValue. (Closed)

Created:
5 years, 9 months ago by rickyz (no longer on Chrome)
Modified:
5 years, 9 months ago
CC:
chromium-reviews, rickyz+watch_chromium.org, jln+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add return statement to LinuxCapabilityToKernelValue. The return statement should never be reached due to the LOG(FATAL), but some compilers seem to think that it is possible to reach the end of this function. TBR=jln@chromium.org Committed: https://crrev.com/eba228e0f27bef5170764bc2f8a9b7f96e389446 Cr-Commit-Position: refs/heads/master@{#320895}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M sandbox/linux/services/credentials.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
rickyz (no longer on Chrome)
5 years, 9 months ago (2015-03-17 09:56:57 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1017623003/1
5 years, 9 months ago (2015-03-17 11:32:24 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 9 months ago (2015-03-17 11:35:35 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/eba228e0f27bef5170764bc2f8a9b7f96e389446 Cr-Commit-Position: refs/heads/master@{#320895}
5 years, 9 months ago (2015-03-17 11:36:21 UTC) #6
jln (very slow on Chromium)
5 years, 9 months ago (2015-03-17 19:17:19 UTC) #7
Message was sent while issue was closed.
lgtm, thanks

Powered by Google App Engine
This is Rietveld 408576698