Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: remoting/webapp/js_proto/qunit_proto.js

Issue 1017613002: Migrate Remoting Webapp Unittests to use QUnit 2.0 syntax. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Reviewer's feedback Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/js_proto/qunit_proto.js
diff --git a/remoting/webapp/js_proto/qunit_proto.js b/remoting/webapp/js_proto/qunit_proto.js
index 8eb96452f3a29176ff3393156f14a0fbad227fb6..a6a2c90f0f8681fc2792928d01a6b71635b42685 100644
--- a/remoting/webapp/js_proto/qunit_proto.js
+++ b/remoting/webapp/js_proto/qunit_proto.js
@@ -49,10 +49,18 @@ QUnit.equal = function(a, b, opt_message) {};
QUnit.expect = function(a) {};
/**
+ * @typedef {{
+ * beforeEach: (function(void) | undefined),
+ * afterEach: (function(void) | undefined)
+ * }}
+ */
+QUnit.ModuleArgs;
+
+/**
* @param {string} desc
- * @param {Object=} dict
+ * @param {QUnit.ModuleArgs=} opt_args=
*/
-QUnit.module = function(desc, dict) {};
+QUnit.module = function(desc, opt_args) {};
/**
* @param {*} a
@@ -68,11 +76,9 @@ QUnit.notEqual = function(a, b, opt_desc) {};
*/
QUnit.ok = function(cond, desc) {};
-QUnit.start = function() {};
-
/**
* @param {string} desc
- * @param {Function} f
+ * @param {function(QUnit.Assert=)} f
John Williams 2015/03/17 19:22:37 Just {function(QUnit.Assert)}; using {function(QUn
*/
QUnit.test = function(desc, f) {};
@@ -88,11 +94,3 @@ QUnit.Assert = function() {};
* @return {function():void}
*/
QUnit.Assert.prototype.async = function() {};
-
-var deepEqual = QUnit.deepEqual;
-var equal = QUnit.equal;
-var expect = QUnit.expect;
-var module = QUnit.module;
-var notEqual = QUnit.notEqual;
-var ok = QUnit.ok;
-var test = QUnit.test;

Powered by Google App Engine
This is Rietveld 408576698