Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(396)

Unified Diff: remoting/webapp/crd/js/error_unittest.js

Issue 1017613002: Migrate Remoting Webapp Unittests to use QUnit 2.0 syntax. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Async test migration Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/webapp/crd/js/error_unittest.js
diff --git a/remoting/webapp/crd/js/error_unittest.js b/remoting/webapp/crd/js/error_unittest.js
index 31df1b8bcbaf76f34a996e87e5e30405b70944c5..1c2330469702bf5b59805664a49e2b101850397a 100644
--- a/remoting/webapp/crd/js/error_unittest.js
+++ b/remoting/webapp/crd/js/error_unittest.js
@@ -7,9 +7,9 @@
'use strict';
QUnit.module('error', {
- setup: function() {
+ beforeEach: function() {
},
- teardown: function() {
+ afterEach: function() {
}
Jamie 2015/03/17 17:57:15 Can you just remove these empty functions?
kelvinp 2015/03/17 18:13:58 Done.
});
@@ -30,11 +30,11 @@ QUnit.test('error constructor 2', function() {
QUnit.test('hasTag', function() {
var error = new remoting.Error(remoting.Error.Tag.HOST_OVERLOAD);
- QUnit.ok(error.hasTag(remoting.Error.Tag.HOST_OVERLOAD));
- QUnit.ok(error.hasTag(
- remoting.Error.Tag.HOST_OVERLOAD,
- remoting.Error.Tag.HOST_IS_OFFLINE));
- QUnit.ok(!error.hasTag(remoting.Error.Tag.HOST_IS_OFFLINE));
+ QUnit.ok(error.hasTag(remoting.Error.Tag.HOST_OVERLOAD));
+ QUnit.ok(error.hasTag(
+ remoting.Error.Tag.HOST_OVERLOAD,
+ remoting.Error.Tag.HOST_IS_OFFLINE));
+ QUnit.ok(!error.hasTag(remoting.Error.Tag.HOST_IS_OFFLINE));
Jamie 2015/03/17 17:57:16 Indentation.
kelvinp 2015/03/17 18:13:58 Done.
});
QUnit.test('constructor methods', function() {

Powered by Google App Engine
This is Rietveld 408576698